Skip to content

Commit b4d31b3

Browse files
authored
Merge pull request #84 from FlutterGen/replace-test-coverage
chore(coverage): replace test_coverage
2 parents 992fd75 + 3b6685d commit b4d31b3

File tree

7 files changed

+14
-38
lines changed

7 files changed

+14
-38
lines changed

.github/workflows/dart-ci.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ jobs:
1919
with:
2020
channel: 'stable'
2121

22+
- name: Set environment
23+
run: echo "$HOME/.pub-cache/bin" >> $GITHUB_PATH
24+
2225
- name: Get dart dependencies.
2326
run: make dependencies
2427

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ node_modules/
108108

109109
## Test coverage
110110
coverage/
111-
**/test/.test_coverage.dart
111+
coverage.lcov
112112

113113
## Test resources
114114
**/test_resources/lib

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ unit-test:
3535
cd packages/core/ && dart pub run test && cd ..
3636

3737
coverage:
38-
cd packages/core/ && dart pub run test_coverage --no-badge && cd ..
38+
./scripts/coverage.sh packages/core
3939
./scripts/codecov.sh ${CODECOV_TOKEN}
4040

4141
setup-ubuntu:

packages/core/pubspec.lock

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -267,13 +267,6 @@ packages:
267267
url: "https://pub.dartlang.org"
268268
source: hosted
269269
version: "3.5.1"
270-
lcov:
271-
dependency: transitive
272-
description:
273-
name: lcov
274-
url: "https://pub.dartlang.org"
275-
source: hosted
276-
version: "5.7.0"
277270
logging:
278271
dependency: transitive
279272
description:
@@ -498,15 +491,6 @@ packages:
498491
url: "https://pub.dartlang.org"
499492
source: hosted
500493
version: "0.3.11+4"
501-
test_coverage:
502-
dependency: "direct dev"
503-
description:
504-
path: "."
505-
ref: HEAD
506-
resolved-ref: d51c9577f78893e1654de8b7c1e92d2f8097838a
507-
url: "https://github.com/shyndman/test-coverage.git"
508-
source: git
509-
version: "0.4.0"
510494
time:
511495
dependency: transitive
512496
description:

packages/core/pubspec.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ dependencies:
2727

2828
dev_dependencies:
2929
test: ^1.15.7
30-
test_coverage:
31-
git: https://github.com/shyndman/test-coverage.git # TODO: https://github.com/pulyaevskiy/test-coverage/issues/14
3230
effective_dart: ^1.3.0
3331
build_runner: ^1.11.1
3432
json_serializable: ^3.5.1

packages/core/test/.test_coverage.dart

Lines changed: 0 additions & 18 deletions
This file was deleted.

scripts/coverage.sh

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
#!/usr/bin/env bash
2+
3+
set -o pipefail
4+
5+
DIR="${1}"
6+
cd ${DIR}
7+
dart pub global activate coverage
8+
dart test --coverage="coverage"
9+
format_coverage --lcov --in=coverage --out=coverage.lcov --packages=.packages --report-on=lib

0 commit comments

Comments
 (0)