Skip to content

Commit 64d4c8f

Browse files
committed
replace the raw response from an account transaction with that of the equivalent requeried transaction response
1 parent 6362f4a commit 64d4c8f

File tree

6 files changed

+19
-7
lines changed

6 files changed

+19
-7
lines changed

raveandroid/src/main/java/com/flutterwave/raveandroid/account/AccountContract.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ interface View {
2929

3030
void onPaymentFailed(String status, String responseAsJSONString);
3131

32-
void onValidateSuccessful(String message, String responseAsJSONString);
32+
void onValidateSuccessful(String flwRef, String responseAsJSONString);
3333

3434
void onValidateError(String message, String responseAsJSONString);
3535

raveandroid/src/main/java/com/flutterwave/raveandroid/account/AccountFragment.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -380,9 +380,9 @@ public void onPaymentFailed(String status, String responseAsJSONString) {
380380
}
381381

382382
@Override
383-
public void onValidateSuccessful(String status, String responseAsJsonString) {
383+
public void onValidateSuccessful(String flwRef, String responseAsJsonString) {
384384
dismissSheets();
385-
onPaymentSuccessful(status, responseAsJsonString);
385+
presenter.requeryTx(flwRef, ravePayInitializer.getSecretKey());
386386
}
387387

388388
@Override

raveandroid/src/main/java/com/flutterwave/raveandroid/account/AccountPresenter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ public void onError(String message, String responseAsJSONString) {
9696
}
9797

9898
@Override
99-
public void validateAccountCharge(String flwRef, String otp, String PBFPubKey) {
99+
public void validateAccountCharge(final String flwRef, String otp, String PBFPubKey) {
100100

101101
ValidateChargeBody body = new ValidateChargeBody();
102102
body.setPBFPubKey(PBFPubKey);
@@ -115,7 +115,7 @@ public void onSuccess(ChargeResponse response, String responseAsJSONString) {
115115
String message = response.getMessage();
116116

117117
if (status.equalsIgnoreCase("success")) {
118-
mView.onValidateSuccessful(status, responseAsJSONString);
118+
mView.onValidateSuccessful(flwRef, responseAsJSONString);
119119
}
120120
else {
121121
mView.onValidateError(status, responseAsJSONString);

raveandroid/src/main/java/com/flutterwave/raveandroid/card/CardContract.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ interface View {
5454
void onAVS_VBVSECURECODEModelSuggested(Payload payload);
5555

5656
void onAVSVBVSecureCodeModelUsed(String authurl, String flwRef);
57+
58+
void onValidateCardChargeFailed(String flwRef, String responseAsJSON);
5759
}
5860

5961
interface UserActionsListener {

raveandroid/src/main/java/com/flutterwave/raveandroid/card/CardFragment.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,16 @@ public void onClick(View v) {
245245

246246
}
247247

248+
@Override
249+
public void onValidateCardChargeFailed(String flwRef, String responseAsJSON) {
250+
251+
dismissDialog();
252+
bottomSheetBehaviorVBV.setState(BottomSheetBehavior.STATE_COLLAPSED);
253+
254+
presenter.requeryTx(flwRef, ravePayInitializer.getSecretKey(), false);
255+
256+
}
257+
248258
/**
249259
* Validate card details and get the fee if available
250260
*/

raveandroid/src/main/java/com/flutterwave/raveandroid/card/CardPresenter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ public void onError(String message, String responseAsJSONString) {
172172
}
173173

174174
@Override
175-
public void validateCardCharge(String flwRef, String otp, String PBFPubKey) {
175+
public void validateCardCharge(final String flwRef, String otp, String PBFPubKey) {
176176

177177
ValidateChargeBody body = new ValidateChargeBody();
178178
body.setPBFPubKey(PBFPubKey);
@@ -198,7 +198,7 @@ public void onSuccess(ChargeResponse response, String responseAsJSONString) {
198198
}
199199
}
200200
else {
201-
mView.onPaymentFailed("Invalid charge card response", responseAsJSONString);
201+
mView.onValidateCardChargeFailed(flwRef, responseAsJSONString);
202202
}
203203
}
204204

0 commit comments

Comments
 (0)