Skip to content

Commit e67d55a

Browse files
committed
remove hard references of secretkey from RavePayActivity
1 parent ec7917f commit e67d55a

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

raveandroid/src/main/java/com/flutterwave/raveandroid/card/CardContract.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,9 @@ interface View {
6363
}
6464

6565
interface UserActionsListener {
66-
void chargeCard(Payload payload);
66+
void chargeCard(Payload payload, String secretKey);
6767

68-
void chargeCardWithSuggestedAuthModel(Payload payload, String pin, String authModel);
68+
void chargeCardWithSuggestedAuthModel(Payload payload, String zipOrPin, String authModel, String secretKey);
6969

7070
void validateCardCharge(String flwRef, String otp, String PBFPubKey);
7171

raveandroid/src/main/java/com/flutterwave/raveandroid/card/CardFragment.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,7 @@ public void onClick(View v) {
442442
pinTil.setError("Enter a valid pin");
443443
}
444444
else {
445-
presenter.chargeCardWithSuggestedAuthModel(payload, pin, PIN);
445+
presenter.chargeCardWithSuggestedAuthModel(payload, pin, PIN, ravePayInitializer.getSecretKey());
446446
}
447447
}
448448
});
@@ -705,7 +705,7 @@ public void onClick(DialogInterface dialog, int which) {
705705
dialog.dismiss();
706706

707707
if (why == RaveConstants.MANUAL_CARD_CHARGE) {
708-
presenter.chargeCard(payload);
708+
presenter.chargeCard(payload, ravePayInitializer.getSecretKey());
709709
}
710710
else if (why == RaveConstants.TOKEN_CHARGE) {
711711
presenter.chargeToken(payload);
@@ -775,7 +775,7 @@ public void onClick(View v) {
775775
}
776776
else {
777777
dialog.dismiss();
778-
presenter.chargeCardWithSuggestedAuthModel(payload, zip, AVS_VBVSECURECODE);
778+
presenter.chargeCardWithSuggestedAuthModel(payload, zip, AVS_VBVSECURECODE, ravePayInitializer.getSecretKey());
779779
}
780780
}
781781
});

raveandroid/src/main/java/com/flutterwave/raveandroid/card/CardPresenter.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import com.flutterwave.raveandroid.RaveConstants;
88
import com.flutterwave.raveandroid.FeeCheckRequestBody;
99
import com.flutterwave.raveandroid.Payload;
10-
import com.flutterwave.raveandroid.RavePayActivity;
1110
import com.flutterwave.raveandroid.RavePayInitializer;
1211
import com.flutterwave.raveandroid.Utils;
1312
import com.flutterwave.raveandroid.data.Callbacks;
@@ -40,10 +39,10 @@ public CardPresenter(Context context, CardContract.View mView) {
4039
}
4140

4241
@Override
43-
public void chargeCard(final Payload payload) {
42+
public void chargeCard(final Payload payload, String secretKey) {
4443

4544
String cardRequestBodyAsString = Utils.convertChargeRequestPayloadToJson(payload);
46-
String encryptedCardRequestBody = Utils.getEncryptedData(cardRequestBodyAsString, RavePayActivity.getSecretKey()).trim().replaceAll("\\n", "");
45+
String encryptedCardRequestBody = Utils.getEncryptedData(cardRequestBodyAsString, secretKey).trim().replaceAll("\\n", "");
4746

4847
// Log.d("encrypted", encryptedCardRequestBody);
4948

@@ -102,8 +101,9 @@ public void onError(String message, String responseAsJSONString) {
102101
});
103102
}
104103

104+
105105
@Override
106-
public void chargeCardWithSuggestedAuthModel(Payload payload, String zipOrPin, String authModel) {
106+
public void chargeCardWithSuggestedAuthModel(Payload payload, String zipOrPin, String authModel, String secretKey) {
107107

108108
if (authModel.equalsIgnoreCase(AVS_VBVSECURECODE)) {
109109
payload.setBillingzip(zipOrPin);
@@ -115,7 +115,7 @@ else if (authModel.equalsIgnoreCase(PIN)){
115115
payload.setSuggestedAuth(authModel);
116116

117117
String cardRequestBodyAsString = Utils.convertChargeRequestPayloadToJson(payload);
118-
String encryptedCardRequestBody = Utils.getEncryptedData(cardRequestBodyAsString, RavePayActivity.getSecretKey()).trim().replaceAll("\\n", "");
118+
String encryptedCardRequestBody = Utils.getEncryptedData(cardRequestBodyAsString, secretKey).trim().replaceAll("\\n", "");
119119

120120
// Log.d("encrypted", encryptedCardRequestBody);
121121

@@ -219,6 +219,7 @@ public void requeryTx(final String flwRef, final String SECKEY, final boolean sh
219219
body.setSECKEY(SECKEY);
220220

221221
mView.showFullProgressIndicator(true);
222+
mView.showProgressIndicator(true);
222223

223224
new NetworkRequestImpl().requeryTx(body, new Callbacks.OnRequeryRequestComplete() {
224225
@Override

0 commit comments

Comments
 (0)