Memoize col in conv_im2col functions to reduce allocations #635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a memo in the
conv_im2col
functions which is used to memoizecol
(some scratchspace those functions use).This dramatically reduces allocations for convolutional layers and increases throughput.
There is a new public function
free_scratchspace_memo!
to clear that memo, should the end user wish to do so once they are done usingconv
.Before (using ObjectDetector as a benchmark):
After:
We saved 50 GiB of allocations!
An alternative design is to plumb the
col
parameter through lots of intermediate generated functions, which seems quite complex.PR Checklist