diff --git a/src/conv.jl b/src/conv.jl index fc00f46d0..702ac7ee8 100644 --- a/src/conv.jl +++ b/src/conv.jl @@ -188,7 +188,7 @@ for (front_name, backend, signature) in ( in2::AbstractArray{$(signature[3][1]), $(signature[1][2])}, cdims::$(signature[4]); kwargs...) where {$(signature[5]...)} - if $(string(backend)) == "direct" && yT == Float64 # warn for Float32 + accidental Float64, but don't print warning for ForwardDiff.Dual + if $(string(backend)) == "direct" && yT <: AbstractFloat # warn for accidental mixture of floats, but don't print warning for ForwardDiff.Dual @warn string("Slow fallback implementation invoked for ", $(string(front_name)), "! ", "You probably don't want this; check your datatypes.") yT T1 T2 maxlog=1 end @@ -229,7 +229,7 @@ for (front_name, backend, signature) in ( in2::AbstractArray{$(signature[3][1]), $(signature[1][2])}, cdims::$(signature[4]); kwargs...) where {$(signature[5]...)} - if $(string(backend)) == "direct" && yT == Float64 # warn for Float32 + accidental Float64, but don't print warning for ForwardDiff.Dual + if $(string(backend)) == "direct" && yT <: AbstractFloat # warn for accidental mixture of floats, but don't print warning for ForwardDiff.Dual @warn string("Slow fallback implementation invoked for ", $(string(front_name)), "! ", "You probably don't want this; check your datatypes.") yT T1 T2 maxlog=1 end @@ -272,7 +272,7 @@ for (front_name, backend, signature) in ( in2::AbstractArray{$(signature[3][1]), $(signature[1][2])}, cdims::$(signature[4]); kwargs...) where {$(signature[5]...)} - if $(string(backend)) == "direct" && yT == Float64 # warn for Float32 + accidental Float64, but don't print warning for ForwardDiff.Dual + if $(string(backend)) == "direct" && yT <: AbstractFloat # warn for accidental mixture of floats, but don't print warning for ForwardDiff.Dual @warn string("Slow fallback implementation invoked for ", $(string(front_name)), "! ", "You probably don't want this; check your datatypes.") yT T1 T2 maxlog=1 end @@ -323,7 +323,7 @@ for (front_name, backend, signature) in ( in2::AbstractArray{$(signature[3][1]), $(signature[1][2])}, cdims::$(signature[4]); kwargs...) where {$(signature[5]...)} - if $(string(backend)) == "direct" && yT == Float64 # warn for Float32 + accidental Float64, but don't print warning for ForwardDiff.Dual + if $(string(backend)) == "direct" && yT <: AbstractFloat # warn for accidental mixture of floats, but don't print warning for ForwardDiff.Dual @warn string("Slow fallback implementation invoked for ", $(string(front_name)), "! ", "You probably don't want this; check your datatypes.") yT T1 T2 maxlog=1 end