Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly fix the assignment of Control characters in keymap.tcl #170

Open
cwervo opened this issue Aug 10, 2024 · 1 comment
Open

Properly fix the assignment of Control characters in keymap.tcl #170

cwervo opened this issue Aug 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@cwervo
Copy link
Collaborator

cwervo commented Aug 10, 2024

ab1541b fixes this issue but feels like a hack. I have a hunch that the proper fix is to avoid adding Control_* characters to the list of chars or modifying resolve directly but I can't grok or debug it well tonight.

folk/lib/keymap.tcl

Lines 214 to 224 in b410c06

# takes km, keycode and mod-bitfield, returns [ksym char] tuple
# char is printable representation of ksym, or "" if unprintable
proc resolve {km code mod} {
lassign $km ksyms chars
set kk "$code $mod"
if {![dict exists $ksyms $kk]} return
return [list [dict get $ksyms $kk] [dict_getdef $chars $kk ""]]
}

@cwervo cwervo added the bug Something isn't working label Aug 10, 2024
@cwervo
Copy link
Collaborator Author

cwervo commented Aug 10, 2024

@s-ol curious if you noticed issues with the keyboard editors (not being able to use any of the Control_* commands to save print, move to the front/end of lines) and if you have thoughts on whether or not the commit above is a hack?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant