From 7c3fbf2e7af18e6898f5fabf6f20eb984163d430 Mon Sep 17 00:00:00 2001
From: Nicolas Moreau <nicolas.moreau76@gmail.com>
Date: Tue, 24 Sep 2024 15:50:23 +0200
Subject: [PATCH 1/2] feat: enforce at least one dep with typescript

---
 packages/datasource-customizer/src/decorators/computed/types.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/datasource-customizer/src/decorators/computed/types.ts b/packages/datasource-customizer/src/decorators/computed/types.ts
index d8dd01c0a1..8b22adde2d 100644
--- a/packages/datasource-customizer/src/decorators/computed/types.ts
+++ b/packages/datasource-customizer/src/decorators/computed/types.ts
@@ -8,7 +8,7 @@ export interface ComputedDefinition<
   N extends TCollectionName<S> = TCollectionName<S>,
 > {
   readonly columnType: ColumnType;
-  readonly dependencies: TFieldName<S, N>[];
+  readonly dependencies: [TFieldName<S, N>, ...TFieldName<S, N>[]];
   readonly defaultValue?: unknown;
   readonly enumValues?: string[];
 

From 615d1e2de4261004b98a0b0311b5e0c9327b4485 Mon Sep 17 00:00:00 2001
From: Nicolas Moreau <nicolas.moreau76@gmail.com>
Date: Wed, 25 Sep 2024 20:01:51 +0200
Subject: [PATCH 2/2] feat: improve typing

---
 .../src/plugins/add-external-relation.ts                     | 5 ++++-
 packages/datasource-customizer/src/types.ts                  | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/packages/datasource-customizer/src/plugins/add-external-relation.ts b/packages/datasource-customizer/src/plugins/add-external-relation.ts
index f3a1bcb116..d6a483acee 100644
--- a/packages/datasource-customizer/src/plugins/add-external-relation.ts
+++ b/packages/datasource-customizer/src/plugins/add-external-relation.ts
@@ -13,7 +13,10 @@ export default async function addExternalRelation<
   collectionCustomizer: CollectionCustomizer<S, N>,
   options: { name: string } & OneToManyEmbeddedDefinition<S, N>,
 ): Promise<void> {
-  const primaryKeys = SchemaUtils.getPrimaryKeys(collectionCustomizer.schema) as TFieldName<S, N>[];
+  const primaryKeys = SchemaUtils.getPrimaryKeys(collectionCustomizer.schema) as [
+    TFieldName<S, N>,
+    ...TFieldName<S, N>[],
+  ];
 
   collectionCustomizer.addField(options.name, {
     dependencies: options.dependencies ?? primaryKeys,
diff --git a/packages/datasource-customizer/src/types.ts b/packages/datasource-customizer/src/types.ts
index 9e49a26e10..ee7a8b3aef 100644
--- a/packages/datasource-customizer/src/types.ts
+++ b/packages/datasource-customizer/src/types.ts
@@ -10,7 +10,7 @@ export type OneToManyEmbeddedDefinition<
   N extends TCollectionName<S> = TCollectionName<S>,
 > = {
   schema: Record<string, PrimitiveTypes>;
-  dependencies?: TFieldName<S, N>[];
+  dependencies?: [TFieldName<S, N>, ...TFieldName<S, N>[]];
   listRecords(
     record: TRow<S, N>,
     context: CollectionCustomizationContext<S, N>,