diff --git a/.changeset/cute-foxes-shop.md b/.changeset/cute-foxes-shop.md new file mode 100644 index 000000000..82e1d0466 --- /dev/null +++ b/.changeset/cute-foxes-shop.md @@ -0,0 +1,5 @@ +--- +"victory-native": patch +--- + +fix native container prop forwarding diff --git a/packages/victory-native/src/components/victory-brush-container.tsx b/packages/victory-native/src/components/victory-brush-container.tsx index 21357314b..d094305b1 100644 --- a/packages/victory-native/src/components/victory-brush-container.tsx +++ b/packages/victory-native/src/components/victory-brush-container.tsx @@ -29,12 +29,12 @@ const RectWithStyle = ({ export const VictoryBrushContainer = ( initialProps: VictoryBrushContainerNativeProps, ) => { - const props = useVictoryBrushContainer({ + const { props, children } = useVictoryBrushContainer({ ...initialProps, brushComponent: initialProps.brushComponent ?? , handleComponent: initialProps.handleComponent ?? , }); - return ; + return {children}; }; VictoryBrushContainer.role = "container"; diff --git a/packages/victory-native/src/components/victory-cursor-container.tsx b/packages/victory-native/src/components/victory-cursor-container.tsx index d7d4c4688..2de0ca798 100644 --- a/packages/victory-native/src/components/victory-cursor-container.tsx +++ b/packages/victory-native/src/components/victory-cursor-container.tsx @@ -20,12 +20,12 @@ export interface VictoryCursorContainerNativeProps export const VictoryCursorContainer = ( initialProps: VictoryCursorContainerNativeProps, ) => { - const props = useVictoryCursorContainer({ + const { props, children } = useVictoryCursorContainer({ ...initialProps, cursorLabelComponent: initialProps.cursorLabelComponent ?? , cursorComponent: initialProps.cursorComponent ?? , }); - return ; + return {children}; }; VictoryCursorContainer.role = "container"; diff --git a/packages/victory-native/src/components/victory-selection-container.tsx b/packages/victory-native/src/components/victory-selection-container.tsx index 4c0f0fcc7..6601c8a31 100644 --- a/packages/victory-native/src/components/victory-selection-container.tsx +++ b/packages/victory-native/src/components/victory-selection-container.tsx @@ -29,7 +29,7 @@ const DefaultSelectionComponent = ({ export const VictorySelectionContainer = ( initialProps: VictorySelectionContainerNativeProps, ) => { - const props = useVictorySelectionContainer({ + const { props, children } = useVictorySelectionContainer({ ...initialProps, // @ts-expect-error TODO: standalone is not a valid prop for VictoryContainer, figure out why this is here standalone: initialProps.standalone ?? true, @@ -37,7 +37,7 @@ export const VictorySelectionContainer = ( ), }); - return ; + return {children}; }; VictorySelectionContainer.role = "container"; diff --git a/packages/victory-native/src/components/victory-voronoi-container.tsx b/packages/victory-native/src/components/victory-voronoi-container.tsx index 9e52da35e..10b0ce4a3 100644 --- a/packages/victory-native/src/components/victory-voronoi-container.tsx +++ b/packages/victory-native/src/components/victory-voronoi-container.tsx @@ -21,14 +21,14 @@ const DEFAULT_VORONOI_PADDING = 5; export const VictoryVoronoiContainer = ( initialProps: VictoryVoronoiContainerNativeProps, ) => { - const props = useVictoryVoronoiContainer({ + const { props, children } = useVictoryVoronoiContainer({ ...initialProps, activateData: initialProps.activateData ?? true, activateLabels: initialProps.activateLabels ?? true, labelComponent: initialProps.labelComponent ?? , voronoiPadding: initialProps.voronoiPadding ?? DEFAULT_VORONOI_PADDING, }); - return ; + return {children}; }; VictoryVoronoiContainer.role = "container";