Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI on startup is too wide and displays all buttons #10

Closed
maxwxyz opened this issue Mar 4, 2025 · 6 comments
Closed

UI on startup is too wide and displays all buttons #10

maxwxyz opened this issue Mar 4, 2025 · 6 comments

Comments

@maxwxyz
Copy link
Collaborator

maxwxyz commented Mar 4, 2025

Similar to the addon manager ui issue (FreeCAD/FreeCAD#19973), the same happens now with the telemetry addon:

Image

OS: Windows 11 build 26100
Architecture: x86_64
Version: 1.1.0dev.40504 (Git) Conda
Build type: Release
Branch: main
Hash: 855ad6c70904f911b2ce7114dd1a5bc24da98bd1
Python 3.11.11, Qt 5.15.15, Coin 4.0.3, Vtk 9.3.0, IfcOpenShell 0.0.0, OCC 7.8.1
Locale: German/Germany (de_DE)
Stylesheet/Theme/QtStyle: FreeCAD Dark.qss/FreeCAD Dark/Fusion
Logical/physical DPI: 96/133.772
Installed mods: 
  * Cables 0.1.3
  * CfdOF 1.29.8
  * CurvedShapes 1.0.13
  * Curves 0.6.58
  * dodo 1.0.1
  * fasteners 0.5.37
  * freecad.gears 1.3.0
  * Manipulator 1.5.7
  * OpenTheme 2024.9.1
  * OpticsWorkbench 1.1.2
  * parts_library
  * Rocket 4.1.1
  * sheetmetal 0.7.21
  * Silk 0.1.5
  * Telemetry 1.0.0


@maxwxyz
Copy link
Collaborator Author

maxwxyz commented Mar 4, 2025

I have noticed, this dialog does not respect the FreeCAD theme, as I have set it to dark and it looks like Classic (which should be disabled on Windows) @chennes @MisterMakerNL

@MisterMakerNL
Copy link

Is this made using QML?

@chennes
Copy link
Member

chennes commented Mar 4, 2025

No, it's Qt Widgets. I suspect this is a difference between Qt5 and Qt6.

@chennes
Copy link
Member

chennes commented Mar 4, 2025

In the file "Resources/panels/first_start.ui" can you look for the code block that looks like this:

<property name="standardButtons">
      <set>QDialogButtonBox::StandardButton::Ok</set>
</property>

and try replacing QDialogButtonBox::StandardButton::Ok with QDialogButtonBox::Ok? (and delete the parameter /Preferences/Mod/Telemetry/FirstStart so the dialog appears on your next launch)

@maxwxyz
Copy link
Collaborator Author

maxwxyz commented Mar 4, 2025

@chennes yes this fixes the issue (but the dialog still does not respect the theme settings):

Image

@chennes
Copy link
Member

chennes commented Mar 4, 2025

Should be fixed by 77f5e9c (obviously the theme thing is a separate bug).

@chennes chennes closed this as completed Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants