Missing DNS callbacks (#1206)

* Removes the code that needlessly clears the DNS callback list.
This code is causing DNS callbacks to not get called when the queries time out.

* Fix unit tests

---------

Co-authored-by: Emil Popov <[email protected]>
Co-authored-by: tony-josi-aws <[email protected]>

Author: 3 people

source/FreeRTOS_IP.c

@@ -670,15 +670,6 @@ void vIPNetworkUpCalls( struct xNetworkEndPoint * pxEndPoint )
     #endif
     #endif /* ipconfigUSE_NETWORK_EVENT_HOOK */
 
-    #if ( ipconfigDNS_USE_CALLBACKS != 0 )
-    {
-        /* The following function is declared in FreeRTOS_DNS.c and 'private' to
-         * this library */
-        extern void vDNSInitialise( void );
-        vDNSInitialise();
-    }
-    #endif /* ipconfigDNS_USE_CALLBACKS != 0 */
-
     /* Set remaining time to 0 so it will become active immediately. */
     if( pxEndPoint->bits.bIPv6 == pdTRUE_UNSIGNED )
     {

test/unit-test/FreeRTOS_IP/FreeRTOS_IP_utest.c

@@ -174,7 +174,6 @@ void test_vIPNetworkUpCalls( void )
     xEndPoint.bits.bIPv6 = pdFALSE;
 
     vApplicationIPNetworkEventHook_Multi_Expect( eNetworkUp, &xEndPoint );
-    vDNSInitialise_Expect();
     vARPTimerReload_Expect( pdMS_TO_TICKS( 10000 ) );
 
     vIPNetworkUpCalls( &xEndPoint );
@@ -4369,7 +4368,6 @@ static void prvIPNetworkUpCalls_Generic( const uint8_t * pucAddress,
     }
 
     vApplicationIPNetworkEventHook_Multi_Expect( eNetworkUp, &xEndPoint );
-    vDNSInitialise_Expect();
 
     if( xEndPoint.bits.bIPv6 == pdTRUE_UNSIGNED )
     {

test/unit-test/FreeRTOS_IP_DiffConfig1/FreeRTOS_IP_DiffConfig1_utest.c

@@ -420,7 +420,6 @@ void test_vIPNetworkUpCalls_BackwardCompatible( void )
     NetworkEndPoint_t xEndPoint = { 0 };
 
     vApplicationIPNetworkEventHook_Expect( eNetworkUp );
-    vDNSInitialise_Expect();
     vARPTimerReload_Expect( pdMS_TO_TICKS( 10000 ) );
 
     vIPNetworkUpCalls( &xEndPoint );