Morning-Session: peer to peer code review.

[Shubh-Dev]

Greetings,
You have done an excellent job.
However, I found some issues when we try to add a new book.
When we try to add a new book a dialogue box pops up and says "Please fill out this field".
I think it would be better if you look into this issue for a better user experience.
Keep it up with your good work.

Happy coding.

[wuletawwonte]

Hello team,
You did an excellent job 👏👏. In addition to @Shubh-Dev suggestions, It is also a good practice to implement dom-manipulation outside of the Book class. Because that will let you use the Book class without worrying about side effects. It also increases the reusability of the class.

[Shubh-Dev]

Hi Wuletaw, Thank you for adding more issues.👍😊

…

On Fri, Mar 18, 2022 at 1:19 PM Wuletaw Wonte ***@***.***> wrote: Hello team, You did an excellent job 👏👏. In addition to @Shubh-Dev <https://github.com/Shubh-Dev> suggestions, It is also a good practice to implement dom-manipulation outside of the Book class. Because that will let you use the Book class without worrying about side effects. It also increases the reusability of the class. — Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AK7ZMTCAUH55MGPIG75ZBZ3VAQYQTANCNFSM5RBB7GCA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Best, Shubh M Das

[BasitKorede]

Hello this as been a good project you have all done an excellent job here I don't have any thing to say than this is a good one