Skip to content

Conversation

@mickesv
Copy link

@mickesv mickesv commented Nov 13, 2019

Hi,
In reference to the discussion in #162 .

There are a few caveats:

  • I had to resort to an ugly hack to fool dired-hide-details into not swallowing the previews as well. I'm sure there's a better solution for this.
  • all-the-icons gets confused and throws in icons at the start of every line. I guess the hack above was too much for it.

As you can see, in the end I did not make dired-subtree a sub-case of an inline-preview since a subtree is (as far as I can foresee) the only "preview" which works differently insofar as it is interactive and you can continue to nest more sub-trees and work with files inside subtrees.

I have no experience in preparing a package proper (I've mostly tinkered on my spare time), so I am hoping you will have the time to help out with this.

@Fuco1
Copy link
Owner

Fuco1 commented Nov 14, 2019

Awesome, I'm really hyped for this one! I think we could also reuse some parts of this package in the dired-images which I haven't really worked on for years but I have a preview feature in my notes as well.

I'll try to get to a review on the weekend, today and tomorrow some of my colleagues came from Holland to visit so we're going to spend some time... working socializing.

@fbob
Copy link

fbob commented Aug 30, 2020

Status of this one: will it be implemented in the next release of dired-hacks ?

@Fuco1 Fuco1 assigned Fuco1 and unassigned Fuco1 Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

3 participants