Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Code Deprecated During assembleTx Implementation #3814

Open
22 tasks
Torres-ssf opened this issue Mar 27, 2025 · 4 comments
Open
22 tasks

Remove Code Deprecated During assembleTx Implementation #3814

Torres-ssf opened this issue Mar 27, 2025 · 4 comments
Labels
Breaking Change chore Issue is a chore

Comments

@Torres-ssf
Copy link
Contributor

Torres-ssf commented Mar 27, 2025

This issue is a remainder to remove all deprecated methods during the assembleTx implementation, as well as any previously deprecated methods.

They are:

  • Account.fund
  • Account.getTransactionCost
  • Provider.getTransactionCost
  • Provider.NodeInfoAndConsensusParameters (type)
  • BaseTransactionRequest.fundWithFakeUtxos
  • ScriptTransactionRequest.estimateAndFund
  • BaseInvocationScope.addSigners
  • BaseInvocationScope.addSignersCallback
  • BaseInvocationScope.getTransactionCost
  • BaseInvocationScope.legacyFundWithRequiredCoins
  • BaseInvocationScope.dryRun
  • Address.fromPublicKey
  • Address.fromB256
  • Address.fromString
  • Address.fromAddressOrString
  • Address.fromDynamicInput
  • Address.fromEvmAddress
  • processGqlReceipt
  • assembleReceiptByType
  • getAllDecodedLogs
  • getAllResultLogs
  • ErrorCode.HASHER_LOCKED
@petertonysmith94
Copy link
Contributor

Should we have as generalised deprecations issues, just because I have a couple from #3805 to be added

@Torres-ssf
Copy link
Contributor Author

@petertonysmith94 I've updated the issue

@petertonysmith94
Copy link
Contributor

@petertonysmith94 I've updated the issue

You're really on one today. 🚀

Copy link
Member

arboleya commented Apr 1, 2025

I've moved this from Blocked to TODO so we don't lose track of it.

Btw, when should we make these changes? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change chore Issue is a chore
Projects
None yet
Development

No branches or pull requests

3 participants