refactor: fix creation of mass handling. (#3215)

Author: CusiniM

.integrated_tests.yaml

@@ -1,6 +1,6 @@
 baselines:
   bucket: geosx
-  baseline: integratedTests/baseline_integratedTests-pr3233-6393-534ac25
+  baseline: integratedTests/baseline_integratedTests-pr3215-6396-9b43cc8
 
 allow_fail:
   all: ''

BASELINE_NOTES.md

@@ -6,10 +6,16 @@ This file is designed to track changes to the integrated test baselines.
 Any developer who updates the baseline ID in the .integrated_tests.yaml file is expected to create an entry in this file with the pull request number, date, and their justification for rebaselining.
 These notes should be in reverse-chronological order, and use the following time format: (YYYY-MM-DD).
 
+PR #3215 (2024-07-23)
+======================
+Changed the default value for massCreation and name of the wrapper.
+
+
 PR #3194 (2024-07-22)
 ======================
 Check pore volume for all element types, also check that default aperture > 0. Rebaseline for modified tests. No real results change.
 
+
 PR #3213 (2024-07-12)
 ======================
 Added baselines for new tests on Dirichlet boundary conditions for multiphase flow.

src/coreComponents/mesh/SurfaceElementRegion.cpp

@@ -106,11 +106,8 @@ localIndex SurfaceElementRegion::addToFractureMesh( real64 const time_np1,
 
   arrayView1d< real64 > const ruptureTime = subRegion.getField< fields::ruptureTime >();
 
-  arrayView1d< real64 > const creationMass = subRegion.getReference< real64_array >( FaceElementSubRegion::viewKeyStruct::creationMassString() );
-
   arrayView2d< real64 const > const faceCenter = faceManager->faceCenter();
   arrayView2d< real64 > const elemCenter = subRegion.getElementCenter();
-  arrayView1d< real64 const > const elemArea = subRegion.getElementArea().toViewConst();
 
   arrayView1d< integer > const subRegionGhostRank = subRegion.ghostRank();
 
@@ -212,8 +209,6 @@ localIndex SurfaceElementRegion::addToFractureMesh( real64 const time_np1,
 
   subRegion.calculateSingleElementGeometricQuantities( kfe, faceManager->faceArea() );
 
-  creationMass[kfe] *= elemArea[kfe];
-
   // update the sets
   for( auto const & setIter : faceManager->sets().wrappers() )
   {

src/coreComponents/mesh/SurfaceElementSubRegion.cpp

@@ -59,11 +59,6 @@ SurfaceElementSubRegion::SurfaceElementSubRegion( string const & name,
     setPlotLevel( PlotLevel::NOPLOT ).
     setDescription( "A map of face element local indices to the cell local indices" );
 
-  registerWrapper< real64_array >( viewKeyStruct::creationMassString() ).
-    setApplyDefaultValue( 0.0 ).
-    setPlotLevel( dataRepository::PlotLevel::LEVEL_1 ).
-    setDescription( "The amount of remaining mass that was introduced when the SurfaceElement was created." );
-
   registerField( fields::elementAperture{}, &m_elementAperture );
 
   registerField( fields::elementArea{}, &m_elementArea );

src/coreComponents/mesh/SurfaceElementSubRegion.hpp

@@ -277,9 +277,6 @@ class SurfaceElementSubRegion : public ElementSubRegionBase
     /// @return Face element to cell indices map string.
     static constexpr char const * surfaceElementsToCellIndexString() { return "fractureElementsToCellIndices"; }
 
-    /// @return Mass creation string.
-    constexpr static char const * creationMassString() { return "creationMass"; }
-
     /// @return surface element to parent plane string.
     constexpr static char const * surfaceElementToParentPlaneString() { return "surfaceElementToParentPlane"; }
   };

src/coreComponents/physicsSolvers/fluidFlow/FlowSolverBaseFields.hpp

@@ -273,6 +273,14 @@ DECLARE_FIELD( energy_n,
                WRITE_AND_READ,
                "Energy at the previous converged time step" );
 
+DECLARE_FIELD( massCreated,
+               "massCreated",
+               array1d< real64 >,
+               0,
+               LEVEL_1,
+               WRITE_AND_READ,
+               "The amount of remaining mass that was introduced when the SurfaceElement was created." );
+
 }
 
 }

src/coreComponents/physicsSolvers/fluidFlow/SinglePhaseBase.cpp

@@ -96,12 +96,20 @@ void SinglePhaseBase::registerDataOnMesh( Group & meshBodies )
       subRegion.registerField< fields::flow::mass >( getName() );
       subRegion.registerField< fields::flow::mass_n >( getName() );
 
+
       if( m_isThermal )
       {
         subRegion.registerField< dMobility_dTemperature >( getName() );
       }
     } );
 
+    elemManager.forElementSubRegions< SurfaceElementSubRegion >( regionNames,
+                                                                 [&]( localIndex const,
+                                                                      SurfaceElementSubRegion & subRegion )
+    {
+      subRegion.registerField< fields::flow::massCreated >( getName() );
+    } );
+
     FaceManager & faceManager = mesh.getFaceManager();
     {
       faceManager.registerField< facePressure >( getName() );
@@ -463,14 +471,8 @@ void SinglePhaseBase::initializePostInitialConditionsPreSubGroups()
     {
       region.forElementSubRegions< FaceElementSubRegion >( [&]( FaceElementSubRegion & subRegion )
       {
-        ConstitutiveBase & fluid = getConstitutiveModel( subRegion, subRegion.getReference< string >( viewKeyStruct::fluidNamesString() )  );
-        real64 const defaultDensity = getFluidProperties( fluid ).defaultDensity;
-
         subRegion.getWrapper< real64_array >( fields::flow::hydraulicAperture::key() ).
           setApplyDefaultValue( region.getDefaultAperture() );
-
-        subRegion.getWrapper< real64_array >( FaceElementSubRegion::viewKeyStruct::creationMassString() ).
-          setApplyDefaultValue( defaultDensity * region.getDefaultAperture() );
       } );
     } );
 
@@ -792,7 +794,7 @@ void SinglePhaseBase::implicitStepComplete( real64 const & time,
     {
       arrayView1d< integer const > const elemGhostRank = subRegion.ghostRank();
       arrayView1d< real64 const > const volume = subRegion.getElementVolume();
-      arrayView1d< real64 > const creationMass = subRegion.getReference< real64_array >( FaceElementSubRegion::viewKeyStruct::creationMassString() );
+      arrayView1d< real64 > const creationMass = subRegion.getField< fields::flow::massCreated >();
 
       SingleFluidBase const & fluid =
         getConstitutiveModel< SingleFluidBase >( subRegion, subRegion.template getReference< string >( viewKeyStruct::fluidNamesString() ) );

src/coreComponents/physicsSolvers/fluidFlow/SinglePhaseBaseKernels.hpp

@@ -356,7 +356,7 @@ class SurfaceElementBasedAssemblyKernel : public ElementBasedAssemblyKernel< Sur
                                      CRSMatrixView< real64, globalIndex const > const & localMatrix,
                                      arrayView1d< real64 > const & localRhs )
     : Base( rankOffset, dofKey, subRegion, fluid, solid, localMatrix, localRhs )
-    , m_creationMass( subRegion.getReference< array1d< real64 > >( SurfaceElementSubRegion::viewKeyStruct::creationMassString() ) )
+    , m_creationMass( subRegion.getField< fields::flow::massCreated >() )
   {}
 
   /**

src/coreComponents/physicsSolvers/fluidFlow/ThermalSinglePhaseBaseKernels.hpp

@@ -332,7 +332,7 @@ class SurfaceElementBasedAssemblyKernel : public ElementBasedAssemblyKernel< Sur
                                      CRSMatrixView< real64, globalIndex const > const & localMatrix,
                                      arrayView1d< real64 > const & localRhs )
     : Base( rankOffset, dofKey, subRegion, fluid, solid, localMatrix, localRhs ),
-    m_creationMass( subRegion.getReference< array1d< real64 > >( SurfaceElementSubRegion::viewKeyStruct::creationMassString() ) )
+    m_creationMass( subRegion.getField< fields::flow::massCreated >() )
   {}
 
   /**