feat: CI - Add code rules checking action #3914
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -114,7 +114,7 @@ jobs: | |
| - name: Check that submodules are up to date | ||
| run: "scripts/test_submodule_updated.sh" | ||
|
|
||
| check_code_standards: | ||
| name: ${{ matrix.name }} | ||
| needs: [is_not_draft_pull_request] | ||
| strategy: | ||
|
|
@@ -127,6 +127,8 @@ jobs: | |
| # Validates that the documentation generated using doxygen has no hole. | ||
| - name: Check documentation | ||
| BUILD_AND_TEST_ARGS: --test-documentation | ||
| # - name: Check code rules | ||
| # BUILD_AND_TEST_ARGS: --test-code-rules | ||
| uses: ./.github/workflows/build_and_test.yml | ||
| with: | ||
| BUILD_AND_TEST_CLI_ARGS: ${{ matrix.BUILD_AND_TEST_ARGS }} | ||
|
|
@@ -137,6 +139,22 @@ jobs: | |
| RUNS_ON: ubuntu-22.04 | ||
| USE_SCCACHE: false | ||
|
|
||
| check_code_rules: | ||
| needs: [is_not_draft_pull_request] | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - name: Checkout Repository | ||
| uses: actions/[email protected] | ||
| with: | ||
| submodules: false | ||
| lfs: false | ||
| fetch-depth: 0 | ||
| sparse-checkout: | | ||
| scripts | ||
| src | ||
| - name: Check the code rules | ||
| run: "scripts/check_code_rules.sh" | ||
|
|
||
| # Matrix containing all the CPU build. | ||
| # Those are quite fast and can efficiently benefit from the `sccache' tool to make them even faster. | ||
| cpu_builds: | ||
|
|
@@ -156,53 +174,53 @@ jobs: | |
| GEOS_ENABLE_BOUNDS_CHECK: ON | ||
| HOST_CONFIG: /spack-generated.cmake | ||
|
|
||
| # - name: Ubuntu debug (20.04, gcc 10.5.0, open-mpi 4.0.3) - github codespaces | ||
| # CMAKE_BUILD_TYPE: Debug | ||
| # DOCKER_REPOSITORY: geosx/ubuntu20.04-gcc10 | ||
| # BUILD_SHARED_LIBS: ON | ||
| # ENABLE_HYPRE: OFF | ||
| # ENABLE_TRILINOS: ON | ||
| # GEOS_ENABLE_BOUNDS_CHECK: ON | ||
| # HOST_CONFIG: /spack-generated.cmake | ||
|
Comment on lines
+177
to
+184
Contributor
There was a problem hiding this comment. you cannot leave CI modifs aimed for test and request review. |
||
|
|
||
| # - name: Ubuntu (20.04, gcc 10.5.0, open-mpi 4.0.3) - github codespaces | ||
| # CMAKE_BUILD_TYPE: Release | ||
| # DOCKER_REPOSITORY: geosx/ubuntu20.04-gcc10 | ||
| # BUILD_SHARED_LIBS: ON | ||
| # ENABLE_HYPRE: OFF | ||
| # ENABLE_TRILINOS: ON | ||
| # GEOS_ENABLE_BOUNDS_CHECK: ON | ||
| # HOST_CONFIG: /spack-generated.cmake | ||
|
|
||
| # - name: Ubuntu (22.04, gcc 11.4.0, open-mpi 4.1.2) | ||
| # CMAKE_BUILD_TYPE: Release | ||
| # DOCKER_REPOSITORY: geosx/ubuntu22.04-gcc11 | ||
| # ENABLE_HYPRE: ON | ||
| # ENABLE_TRILINOS: OFF | ||
| # BUILD_SHARED_LIBS: ON | ||
| # GEOS_ENABLE_BOUNDS_CHECK: OFF | ||
| # GCP_BUCKET: geosx/ubuntu22.04-gcc11 | ||
| # HOST_CONFIG: /spack-generated.cmake | ||
|
|
||
| # - name: Ubuntu (22.04, gcc 12.3.0, open-mpi 4.1.2) | ||
| # CMAKE_BUILD_TYPE: Release | ||
| # DOCKER_REPOSITORY: geosx/ubuntu22.04-gcc12 | ||
| # GCP_BUCKET: geosx/ubuntu22.04-gcc12 | ||
| # ENABLE_HYPRE: ON | ||
| # ENABLE_TRILINOS: OFF | ||
| # BUILD_SHARED_LIBS: ON | ||
| # GEOS_ENABLE_BOUNDS_CHECK: ON | ||
| # HOST_CONFIG: /spack-generated.cmake | ||
|
|
||
| # - name: Ubuntu (22.04, gcc 12.3.0, open-mpi 4.1.2) - NO BOUNDS CHECK | ||
| # CMAKE_BUILD_TYPE: Release | ||
| # DOCKER_REPOSITORY: geosx/ubuntu22.04-gcc12 | ||
| # GCP_BUCKET: geosx/ubuntu22.04-gcc12 | ||
| # ENABLE_HYPRE: ON | ||
| # ENABLE_TRILINOS: OFF | ||
| # BUILD_SHARED_LIBS: ON | ||
| # GEOS_ENABLE_BOUNDS_CHECK: OFF | ||
| # HOST_CONFIG: /spack-generated.cmake | ||
|
|
||
| #- name: Ubuntu (22.04, clang 15.0.7, open-mpi 4.1.2) | ||
| # CMAKE_BUILD_TYPE: Release | ||
|
|
@@ -319,69 +337,69 @@ jobs: | |
| fail-fast : false | ||
| matrix: | ||
| include: | ||
| # - name: Ubuntu CUDA debug (20.04, clang 10.0.0 + gcc 9.4.0, open-mpi 4.0.3, cuda-11.8.89) | ||
| # BUILD_AND_TEST_CLI_ARGS: "--build-exe-only --no-install-schema" | ||
| # CMAKE_BUILD_TYPE: Debug | ||
| # BUILD_GENERATOR: "--ninja" | ||
| # DOCKER_REPOSITORY: geosx/ubuntu20.04-clang10.0.0-cuda11.8.89 | ||
| # ENABLE_HYPRE_DEVICE: CUDA | ||
| # ENABLE_HYPRE: ON | ||
| # ENABLE_TRILINOS: OFF | ||
| # GEOS_ENABLE_BOUNDS_CHECK: OFF | ||
| # RUNS_ON: streak2 | ||
| # NPROC: 8 | ||
| # DOCKER_RUN_ARGS: "--cpus=8 --memory=128g --runtime=nvidia -v /etc/pki/ca-trust/source/anchors/:/usr/local/share/ca-certificates/llnl:ro" | ||
| # DOCKER_CERTS_DIR: "/usr/local/share/ca-certificates" | ||
| # DOCKER_CERTS_UPDATE_COMMAND: "update-ca-certificates" | ||
| # HOST_CONFIG: /spack-generated.cmake | ||
|
|
||
| # - name: Ubuntu CUDA (20.04, clang 10.0.0 + gcc 9.4.0, open-mpi 4.0.3, cuda-11.8.89) | ||
| # BUILD_AND_TEST_CLI_ARGS: "--no-run-unit-tests --no-install-schema" | ||
| # CMAKE_BUILD_TYPE: Release | ||
| # BUILD_GENERATOR: "--ninja" | ||
| # DOCKER_REPOSITORY: geosx/ubuntu20.04-clang10.0.0-cuda11.8.89 | ||
| # ENABLE_HYPRE_DEVICE: CUDA | ||
| # ENABLE_HYPRE: ON | ||
| # ENABLE_TRILINOS: OFF | ||
| # GEOS_ENABLE_BOUNDS_CHECK: OFF | ||
| # RUNS_ON: streak2 | ||
| # NPROC: 8 | ||
| # DOCKER_RUN_ARGS: "--cpus=8 --memory=256g --runtime=nvidia -v /etc/pki/ca-trust/source/anchors/:/usr/local/share/ca-certificates/llnl:ro" | ||
| # DOCKER_CERTS_DIR: "/usr/local/share/ca-certificates" | ||
| # DOCKER_CERTS_UPDATE_COMMAND: "update-ca-certificates" | ||
| # HOST_CONFIG: /spack-generated.cmake | ||
|
|
||
| # - name: Rockylinux CUDA (8, clang 17.0.6, cuda 12.9.1) | ||
| # BUILD_AND_TEST_CLI_ARGS: "--no-install-schema" | ||
| # CMAKE_BUILD_TYPE: Release | ||
| # BUILD_GENERATOR: "--ninja" | ||
| # ENABLE_HYPRE_DEVICE: CUDA | ||
| # ENABLE_HYPRE: ON | ||
| # ENABLE_TRILINOS: OFF | ||
| # GEOS_ENABLE_BOUNDS_CHECK: OFF | ||
| # DOCKER_REPOSITORY: geosx/rockylinux8-clang17-cuda12.9.1 | ||
| # RUNS_ON: streak | ||
| # NPROC: 8 | ||
| # DOCKER_RUN_ARGS: "--cpus=8 --memory=256g --runtime=nvidia --gpus all -v /etc/pki/ca-trust/source/anchors/:/usr/local/share/ca-certificates/llnl:ro" | ||
| # DOCKER_CERTS_DIR: "/usr/local/share/ca-certificates" | ||
| # DOCKER_CERTS_UPDATE_COMMAND: "update-ca-trust" | ||
| # HOST_CONFIG: /spack-generated.cmake | ||
|
|
||
| # - name: Rockylinux CUDA (8, gcc 13.3, cuda 12.9.1) | ||
| # BUILD_AND_TEST_CLI_ARGS: "--no-run-unit-tests --no-install-schema" | ||
| # CMAKE_BUILD_TYPE: Release | ||
| # BUILD_GENERATOR: "--ninja" | ||
| # ENABLE_HYPRE_DEVICE: CUDA | ||
| # ENABLE_HYPRE: ON | ||
| # ENABLE_TRILINOS: OFF | ||
| # GEOS_ENABLE_BOUNDS_CHECK: OFF | ||
| # DOCKER_REPOSITORY: geosx/rockylinux8-gcc13-cuda12.9.1 | ||
| # RUNS_ON: streak2 | ||
| # NPROC: 8 | ||
| # DOCKER_RUN_ARGS: "--cpus=8 --memory=128g --runtime=nvidia -v /etc/pki/ca-trust/source/anchors/:/etc/pki/ca-trust/source/anchors/llnl:ro" | ||
| # DOCKER_CERTS_DIR: "/etc/pki/ca-trust/source/anchors" | ||
| # DOCKER_CERTS_UPDATE_COMMAND: "update-ca-trust" | ||
| # HOST_CONFIG: /spack-generated.cmake | ||
|
|
||
| - name: Pangea 3 CUDA (AlmaLinux 8.8, gcc 9.4.0, open-mpi 4.1.2, cuda 11.5.0, openblas 0.3.10) | ||
| BUILD_AND_TEST_CLI_ARGS: "--build-exe-only --no-install-schema" | ||
|
|
@@ -447,24 +465,20 @@ jobs: | |
| needs: | ||
| - if_not_unassigned_pull_request | ||
| - are_submodules_in_sync | ||
| - check_code_standards | ||
|
Contributor
There was a problem hiding this comment. If
Contributor
There was a problem hiding this comment. Looking at CI checks, it is indeed then an advisory but not required enforcement ? |
||
| - cpu_builds | ||
| - cuda_builds | ||
| - run_integrated_tests | ||
| if: ${{ always() }} | ||
| steps: | ||
| - run: | | ||
| echo "if_not_unassigned_pull_request: ${{needs.if_not_unassigned_pull_request.result}}" | ||
| echo "are_submodules_in_sync: ${{needs.are_submodules_in_sync.result}}" | ||
| echo "check_code_standards: ${{needs.check_code_standards.result}}" | ||
| echo "run_integrated_tests: ${{needs.run_integrated_tests.result}} " | ||
| ${{ | ||
| needs.if_not_unassigned_pull_request.result == 'success' && | ||
| needs.are_submodules_in_sync.result == 'success' && | ||
| needs.check_code_standards.result == 'success' && | ||
|
Contributor
There was a problem hiding this comment. was |
||
| needs.run_integrated_tests.result == 'success' | ||
| }} | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it commented out?