Sets default symbol visibility to hidden. Resolves #74

jonesmz · jonesmz · commit aea7c1d14413 · 2018-05-13T01:55:31.000-05:00
diff --git a/Source/CMake/Properties.cmake b/Source/CMake/Properties.cmake
@@ -74,7 +74,7 @@ if(MSVC)
 elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang" OR CMAKE_CXX_COMPILER_ID MATCHES "AppleClang")
 	# Note: Optionally add -ffunction-sections, -fdata-sections, but with linker option --gc-sections
 	# TODO: Use link-time optimization -flto. Might require non-default linker.
-	set(BS_COMPILER_FLAGS_COMMON "-Wall -Wextra -Wno-unused-parameter -fPIC -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-ms-compatibility")
+	set(BS_COMPILER_FLAGS_COMMON "-Wall -Wextra -Wno-unused-parameter -fvisibility=hidden -fvisibility-inlines-hidden -fPIC -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-ms-compatibility")
 
 	if(LINUX)
 		set(BS_COMPILER_FLAGS_COMMON "${BS_COMPILER_FLAGS_COMMON} -Wl,-rpath=$ORIGIN")
@@ -94,7 +94,7 @@ elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang" OR CMAKE_CXX_COMPILER_ID MATCHES "A
 
 elseif("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
 	# TODO: Use link-time optimization -flto. Might require non-default linker.
-	set(BS_COMPILER_FLAGS_COMMON "-Wall -Wextra -Wno-unused-parameter -fPIC -fno-exceptions -fno-strict-aliasing -fno-rtti")
+	set(BS_COMPILER_FLAGS_COMMON "-Wall -Wextra -Wno-unused-parameter -fvisibility=hidden -fvisibility-inlines-hidden -fPIC -fno-exceptions -fno-strict-aliasing -fno-rtti")
 
 	if(LINUX)
 		set(BS_COMPILER_FLAGS_COMMON "${BS_COMPILER_FLAGS_COMMON} -Wl,-rpath=$ORIGIN")
diff --git a/Source/Foundation/bsfUtility/Allocators/BsMemoryAllocator.h b/Source/Foundation/bsfUtility/Allocators/BsMemoryAllocator.h
@@ -100,25 +100,24 @@ namespace bs
 	 * Thread safe class used for storing total number of memory allocations and deallocations, primarily for statistic
 	 * purposes.
 	 */
-	class MemoryCounter
+	class BS_UTILITY_EXPORT MemoryCounter
 	{
 	public:
-		static BS_UTILITY_EXPORT uint64_t getNumAllocs()
+		static uint64_t getNumAllocs()
 		{
 			return Allocs;
 		}
 
-		static BS_UTILITY_EXPORT uint64_t getNumFrees()
+		static uint64_t getNumFrees()
 		{
 			return Frees;
 		}
 
 	private:
 		friend class MemoryAllocatorBase;
 
-		// Threadlocal data can't be exported, so some magic to make it accessible from MemoryAllocator
-		static BS_UTILITY_EXPORT void incAllocCount() { ++Allocs; }
-		static BS_UTILITY_EXPORT void incFreeCount() { ++Frees; }
+		static void incAllocCount() { ++Allocs; }
+		static void incFreeCount() { ++Frees; }
 
 		static BS_THREADLOCAL uint64_t Allocs;
 		static BS_THREADLOCAL uint64_t Frees;

Original file line number	Diff line number	Diff line change
`@@ -100,25 +100,24 @@ namespace bs`
`100`	`100`	`* Thread safe class used for storing total number of memory allocations and deallocations, primarily for statistic`
`101`	`101`	`* purposes.`
`102`	`102`	`*/`
`103`		`- class MemoryCounter`
	`103`	`+ class BS_UTILITY_EXPORT MemoryCounter`
`104`	`104`	`{`
`105`	`105`	`public:`
`106`		`- static BS_UTILITY_EXPORT uint64_t getNumAllocs()`
	`106`	`+ static uint64_t getNumAllocs()`
`107`	`107`	`{`
`108`	`108`	`return Allocs;`
`109`	`109`	`}`
`110`	`110`
`111`		`- static BS_UTILITY_EXPORT uint64_t getNumFrees()`
	`111`	`+ static uint64_t getNumFrees()`
`112`	`112`	`{`
`113`	`113`	`return Frees;`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`private:`
`117`	`117`	`friend class MemoryAllocatorBase;`
`118`	`118`
`119`		`- // Threadlocal data can't be exported, so some magic to make it accessible from MemoryAllocator`
`120`		`- static BS_UTILITY_EXPORT void incAllocCount() { ++Allocs; }`
`121`		`- static BS_UTILITY_EXPORT void incFreeCount() { ++Frees; }`
	`119`	`+ static void incAllocCount() { ++Allocs; }`
	`120`	`+ static void incFreeCount() { ++Frees; }`
`122`	`121`
`123`	`122`	`static BS_THREADLOCAL uint64_t Allocs;`
`124`	`123`	`static BS_THREADLOCAL uint64_t Frees;`