From 775edec35ee85b809e64ec99dc19deece118c9c1 Mon Sep 17 00:00:00 2001 From: Bartosz Dominiak Date: Fri, 20 Oct 2023 17:54:34 +0200 Subject: [PATCH 1/2] Update RequestHandler.h with aliases --- Source/GameSwiftSdk/Public/RequestHandler.h | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/Source/GameSwiftSdk/Public/RequestHandler.h b/Source/GameSwiftSdk/Public/RequestHandler.h index 5ef2dfd..eb28073 100644 --- a/Source/GameSwiftSdk/Public/RequestHandler.h +++ b/Source/GameSwiftSdk/Public/RequestHandler.h @@ -11,12 +11,17 @@ class FRequestHandler { public: #if ENGINE_MAJOR_VERSION == 4 && ENGINE_MINOR_VERSION <= 24 - static TSharedRef SendRequest( + using HttpRequestRefType = TSharedRef; #else - static TSharedRef SendRequest( + using HttpRequestRefType = TSharedRef; #endif - FString FullUrl, FString Method, const FString callBody, const FString accessToken, - bool ExpectsWwwResponse = false); + static HttpRequestRefType SendRequest( + const FString& FullUrl, + const FString& Method, + const FString& callBody, + const FString& accessToken, + bool ExpectsWwwResponse = false + ); static bool DecodeRequest(FHttpResponsePtr HttpResponse, bool bSucceeded, FJsonObject& ResultObject, FBaseSdkFailResponse& OutError); From 5e78e5b8f6b48808f64748cf526dadd5faf193df Mon Sep 17 00:00:00 2001 From: Bartosz Dominiak Date: Sat, 21 Oct 2023 11:18:21 +0200 Subject: [PATCH 2/2] Update RequestHandler.h with aliases --- Source/GameSwiftSdk/Private/RequestHandler.cpp | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/Source/GameSwiftSdk/Private/RequestHandler.cpp b/Source/GameSwiftSdk/Private/RequestHandler.cpp index aaa06c2..efc4886 100644 --- a/Source/GameSwiftSdk/Private/RequestHandler.cpp +++ b/Source/GameSwiftSdk/Private/RequestHandler.cpp @@ -5,12 +5,18 @@ #if ENGINE_MAJOR_VERSION == 4 && ENGINE_MINOR_VERSION <= 24 -TSharedRef FRequestHandler::SendRequest( + using HttpRequestRef = TSharedRef; #else -TSharedRef FRequestHandler::SendRequest( + using HttpRequestRef = TSharedRef; #endif - FString FullUrl, FString Method, const FString callBody, const FString accessToken, bool ExpectsWwwResponse) -{ + +HttpRequestRef FRequestHandler::SendRequest( + FString FullUrl, + FString Method, + const FString& callBody, + const FString& accessToken, + bool ExpectsWwwResponse +) { auto HttpRequest = FHttpModule::Get().CreateRequest(); HttpRequest->SetVerb(Method); HttpRequest->SetURL(FullUrl);