Skip to content

Conversation

@Gpetrak
Copy link
Member

@Gpetrak Gpetrak commented Oct 17, 2025

Ref #13627

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@Gpetrak Gpetrak added this to the 5.0.0 milestone Oct 17, 2025
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Oct 17, 2025
@Gpetrak Gpetrak self-assigned this Oct 17, 2025
@Gpetrak Gpetrak linked an issue Oct 17, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 89.42308% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.06%. Comparing base (746dc74) to head (0a8b966).
⚠️ Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13628      +/-   ##
==========================================
+ Coverage   72.52%   74.06%   +1.54%     
==========================================
  Files         931      931              
  Lines       55216    55305      +89     
  Branches     7437     7458      +21     
==========================================
+ Hits        40044    40961     +917     
+ Misses      13569    12717     -852     
- Partials     1603     1627      +24     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Gpetrak Gpetrak marked this pull request as ready for review October 28, 2025 10:42
@giohappy giohappy removed this from the 5.0.0 milestone Oct 29, 2025
@mattiagiupponi mattiagiupponi merged commit a664cee into master Oct 29, 2025
17 checks passed
@mattiagiupponi mattiagiupponi deleted the ISSUE_13627 branch October 29, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a fallback task in order to monitor the session's health

4 participants