Skip to content

Commit a7e0897

Browse files
authored
Merge pull request #11 from Geode-solutions/fix/db-viewer-object
fix(Data): add viewer object
2 parents 656338d + 1288363 commit a7e0897

File tree

2 files changed

+13
-10
lines changed

2 files changed

+13
-10
lines changed

src/opengeodeweb_microservice/database/data.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,11 @@ class Data(Base):
1111
id: Mapped[str] = mapped_column(
1212
String, primary_key=True, default=lambda: str(uuid.uuid4()).replace("-", "")
1313
)
14-
native_file_name: Mapped[str] = mapped_column(String, nullable=False)
15-
viewable_file_name: Mapped[str] = mapped_column(String, nullable=False)
1614
geode_object: Mapped[str] = mapped_column(String, nullable=False)
15+
viewer_object: Mapped[str] = mapped_column(String, nullable=False)
16+
17+
native_file_name: Mapped[str | None] = mapped_column(String, nullable=True)
18+
viewable_file_name: Mapped[str | None] = mapped_column(String, nullable=True)
1719

1820
light_viewable: Mapped[str | None] = mapped_column(String, nullable=True)
1921
input_file: Mapped[str | None] = mapped_column(String, nullable=True)
@@ -22,19 +24,15 @@ class Data(Base):
2224
@staticmethod
2325
def create(
2426
geode_object: str,
27+
viewer_object: str,
2528
input_file: str | None = None,
2629
additional_files: list[str] | None = None,
2730
) -> "Data":
28-
input_file = input_file or ""
29-
additional_files = additional_files or []
30-
3131
data_entry = Data(
3232
geode_object=geode_object,
33+
viewer_object=viewer_object,
3334
input_file=input_file,
3435
additional_files=additional_files,
35-
native_file_name="",
36-
viewable_file_name="",
37-
light_viewable=None,
3836
)
3937

4038
session = get_session()

tests/test_database.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@
33

44
def test_data_crud_operations(clean_database):
55
data = Data.create(
6-
geode_object="test_object", input_file="test.txt", additional_files=[]
6+
geode_object="test_object",
7+
viewer_object="test_viewer",
8+
input_file="test.txt",
9+
additional_files=[],
710
)
811
print("id", data.id, flush=True)
912
assert data.id is not None
@@ -21,7 +24,9 @@ def test_data_crud_operations(clean_database):
2124

2225
def test_data_with_additional_files(clean_database):
2326
files = ["file1.txt", "file2.txt"]
24-
data = Data.create(geode_object="test_files", additional_files=files)
27+
data = Data.create(
28+
geode_object="test_files", viewer_object="test_viewer", additional_files=files
29+
)
2530
assert data.id is not None
2631
assert isinstance(data.id, str)
2732

0 commit comments

Comments
 (0)