Skip to content

Commit d8608b0

Browse files
committed
(build) Fix unit tests
As a result of changes to "how" a release is found from GitHub, it is no longer the case that an exception is thrown, but rather, if a specific release can't be found, it simply returns a null value. The unit tests were updated to reflect this change in functionality.
1 parent a4b9ef4 commit d8608b0

File tree

2 files changed

+11
-15
lines changed

2 files changed

+11
-15
lines changed

src/GitReleaseManager.Core.Tests/Provider/GitHubProviderTests.cs

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -631,30 +631,26 @@ public async Task Should_Get_Release()
631631
var result = await _gitHubProvider.GetReleaseAsync(OWNER, REPOSITORY, TAG_NAME).ConfigureAwait(false);
632632
result.ShouldBeSameAs(release);
633633

634-
await _gitHubClient.Repository.Release.Received(1).Get(OWNER, REPOSITORY, TAG_NAME).ConfigureAwait(false);
634+
await _gitHubClient.Repository.Release.Received(1).GetAll(OWNER, REPOSITORY).ConfigureAwait(false);
635635
_mapper.Received(1).Map<Release>(Arg.Any<object>());
636636
}
637637

638638
[Test]
639-
public async Task Should_Throw_An_Exception_On_Getting_Release_For_Non_Existent_Tag()
639+
public async Task Should_Return_Null_On_Getting_Release_For_Non_Existent_Tag()
640640
{
641641
_gitHubClient.Repository.Release.Get(OWNER, REPOSITORY, TAG_NAME)
642642
.Returns(Task.FromException<Octokit.Release>(_notFoundException));
643643

644-
var ex = await Should.ThrowAsync<NotFoundException>(() => _gitHubProvider.GetReleaseAsync(OWNER, REPOSITORY, TAG_NAME)).ConfigureAwait(false);
645-
ex.Message.ShouldBe(_notFoundException.Message);
646-
ex.InnerException.ShouldBe(_notFoundException);
644+
var release = await _gitHubProvider.GetReleaseAsync(OWNER, REPOSITORY, TAG_NAME).ConfigureAwait(false);
645+
646+
release.ShouldBeNull();
647647
}
648648

649649
[Test]
650-
public async Task Should_Throw_An_Exception_On_Getting_Release()
650+
public async Task Should_Return_Null_Getting_Release()
651651
{
652-
_gitHubClient.Repository.Release.Get(OWNER, REPOSITORY, TAG_NAME)
653-
.Returns(Task.FromException<Octokit.Release>(_exception));
654-
655-
var ex = await Should.ThrowAsync<ApiException>(() => _gitHubProvider.GetReleaseAsync(OWNER, REPOSITORY, TAG_NAME)).ConfigureAwait(false);
656-
ex.Message.ShouldBe(_exception.Message);
657-
ex.InnerException.ShouldBe(_exception);
652+
var release = await _gitHubProvider.GetReleaseAsync(OWNER, REPOSITORY, TAG_NAME).ConfigureAwait(false);
653+
release.ShouldBeNull();
658654
}
659655

660656
[Test]

src/GitReleaseManager.Core.Tests/VcsServiceTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ public async Task Should_Create_Release_From_Milestone()
302302
.Returns(Task.FromResult(RELEASE_NOTES));
303303

304304
_vcsProvider.GetReleaseAsync(OWNER, REPOSITORY, MILESTONE_TITLE)
305-
.Returns(Task.FromException<Release>(_notFoundException));
305+
.Returns(Task.FromResult<Release>(null));
306306

307307
_vcsProvider.CreateReleaseAsync(OWNER, REPOSITORY, Arg.Any<Release>())
308308
.Returns(Task.FromResult(release));
@@ -330,7 +330,7 @@ public async Task Should_Create_Release_From_Milestone_Using_Template_File()
330330
.Returns(Task.FromResult(RELEASE_NOTES));
331331

332332
_vcsProvider.GetReleaseAsync(OWNER, REPOSITORY, MILESTONE_TITLE)
333-
.Returns(Task.FromException<Release>(_notFoundException));
333+
.Returns(Task.FromResult<Release>(null));
334334

335335
_vcsProvider.CreateReleaseAsync(OWNER, REPOSITORY, Arg.Any<Release>())
336336
.Returns(Task.FromResult(release));
@@ -434,7 +434,7 @@ public async Task Should_Create_Release_From_InputFile()
434434
var release = new Release();
435435

436436
_vcsProvider.GetReleaseAsync(OWNER, REPOSITORY, MILESTONE_TITLE)
437-
.Returns(Task.FromException<Release>(_notFoundException));
437+
.Returns(Task.FromResult<Release>(null));
438438

439439
_vcsProvider.CreateReleaseAsync(OWNER, REPOSITORY, Arg.Any<Release>())
440440
.Returns(Task.FromResult(release));

0 commit comments

Comments
 (0)