-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logging mechanism to make use of Serilog #179
Comments
I think we should consider using This will make it easy to switch to another Logging framework in the future if needed. |
That could certainly be done as well. @gep13 thoughts? EDIT: This would require us to implement some kind of DI though. |
I have no objections to bringing that in. I had thought about bringing in DI as well, since it would make the different providers easier to use. |
@gep13 Sounds like more refactoring need to be done then. Most likely we'll need to refactor the code base to have a single class we call for each command (which then again calls out to the correct provider). I opened a draft with the implementation of Serilog, but without DI for now. |
for the DI I would suggest Microsoft.Extensions.DependencyInjection, we used it for GitVersion |
Created #181 for discussing and tracking implementation of a DI framework |
Detailed Description
Update GRM to make use of Serilog for logging purposes (both to file and to console).
Currently the logging mechanism uses custom logic to log text to a file, and normal Console calls to output to the console. However this should be changed to use Serilog instead.
Context
Quoting Gary:
Possible Implementation
Already mentioned.
Your Environment
Not Important
The text was updated successfully, but these errors were encountered: