From 5efec84b8905a7dc79bae4859ce048a01019712f Mon Sep 17 00:00:00 2001 From: Bob Loblaw Date: Sun, 8 Sep 2024 01:00:39 +0200 Subject: [PATCH] Fix tests --- gitreleasemanager/addasset/action.yml | 4 +++ gitreleasemanager/close/action.yml | 4 +++ gitreleasemanager/discard/action.yml | 4 +++ gitreleasemanager/open/action.yml | 4 +++ gitreleasemanager/publish/action.yml | 5 +++ .../tools/gitreleasemanager/settings.spec.ts | 15 ++++++--- .../tools/gitreleasemanager/tool.spec.ts | 31 +++++++++++++++++-- 7 files changed, 59 insertions(+), 8 deletions(-) diff --git a/gitreleasemanager/addasset/action.yml b/gitreleasemanager/addasset/action.yml index edb5ce858..d92d67992 100644 --- a/gitreleasemanager/addasset/action.yml +++ b/gitreleasemanager/addasset/action.yml @@ -32,3 +32,7 @@ inputs: description: The directory on which GitReleaseManager should be executed. Defaults to current directory required: false default: '' + logFilePath: + description: Path to where log file should be created. Defaults to logging to console. + required: false + default: '' diff --git a/gitreleasemanager/close/action.yml b/gitreleasemanager/close/action.yml index 0cad97dca..26169f2fc 100644 --- a/gitreleasemanager/close/action.yml +++ b/gitreleasemanager/close/action.yml @@ -28,3 +28,7 @@ inputs: description: The directory on which GitReleaseManager should be executed. Defaults to current directory required: false default: '' + logFilePath: + description: Path to where log file should be created. Defaults to logging to console. + required: false + default: '' diff --git a/gitreleasemanager/discard/action.yml b/gitreleasemanager/discard/action.yml index 4d2109e6b..326711c8d 100644 --- a/gitreleasemanager/discard/action.yml +++ b/gitreleasemanager/discard/action.yml @@ -28,3 +28,7 @@ inputs: description: The directory on which GitReleaseManager should be executed. Defaults to current directory required: false default: '' + logFilePath: + description: Path to where log file should be created. Defaults to logging to console. + required: false + default: '' diff --git a/gitreleasemanager/open/action.yml b/gitreleasemanager/open/action.yml index 3dfc0ed4a..9063f78b8 100644 --- a/gitreleasemanager/open/action.yml +++ b/gitreleasemanager/open/action.yml @@ -28,3 +28,7 @@ inputs: description: The directory on which GitReleaseManager should be executed. Defaults to current directory required: false default: '' + logFilePath: + description: Path to where log file should be created. Defaults to logging to console. + required: false + default: '' diff --git a/gitreleasemanager/publish/action.yml b/gitreleasemanager/publish/action.yml index 06ad03c6e..38f235b77 100644 --- a/gitreleasemanager/publish/action.yml +++ b/gitreleasemanager/publish/action.yml @@ -28,3 +28,8 @@ inputs: description: The directory on which GitReleaseManager should be executed. Defaults to current directory required: false default: '' + logFilePath: + description: Path to where log file should be created. Defaults to logging to console. + required: false + default: '' + diff --git a/src/__tests__/tools/gitreleasemanager/settings.spec.ts b/src/__tests__/tools/gitreleasemanager/settings.spec.ts index ebd2f96c0..9dee654af 100644 --- a/src/__tests__/tools/gitreleasemanager/settings.spec.ts +++ b/src/__tests__/tools/gitreleasemanager/settings.spec.ts @@ -46,7 +46,8 @@ describe('GitReleaseManager settings', () => { owner: 'owner', token: 'token', targetDirectory: 'path', - milestone: 'milestone' + milestone: 'milestone', + logFilePath: './output.log' } const buildAgent = { @@ -66,7 +67,8 @@ describe('GitReleaseManager settings', () => { owner: 'owner', token: 'token', targetDirectory: 'path', - milestone: 'milestone' + milestone: 'milestone', + logFilePath: './output.log' } const buildAgent = { @@ -86,7 +88,8 @@ describe('GitReleaseManager settings', () => { owner: 'owner', token: 'token', targetDirectory: 'path', - milestone: 'milestone' + milestone: 'milestone', + logFilePath: './output.log' } const buildAgent = { @@ -106,7 +109,8 @@ describe('GitReleaseManager settings', () => { owner: 'owner', token: 'token', targetDirectory: 'path', - milestone: 'milestone' + milestone: 'milestone', + logFilePath: './output.log' } const buildAgent = { @@ -127,7 +131,8 @@ describe('GitReleaseManager settings', () => { token: 'token', targetDirectory: 'path', milestone: 'milestone', - assets: ['asset'] + assets: ['asset'], + logFilePath: './output.log' } const buildAgent = { diff --git a/src/__tests__/tools/gitreleasemanager/tool.spec.ts b/src/__tests__/tools/gitreleasemanager/tool.spec.ts index b14689f44..785554a97 100644 --- a/src/__tests__/tools/gitreleasemanager/tool.spec.ts +++ b/src/__tests__/tools/gitreleasemanager/tool.spec.ts @@ -136,7 +136,8 @@ describe('GitReleaseManagerTool', () => { owner: 'owner', repository: 'repo', token: 'token', - targetDirectory: 'targetDirectory' + targetDirectory: 'targetDirectory', + logFilePath: './logFilePath' } as CommonSettings beforeEach(() => { @@ -162,7 +163,18 @@ describe('GitReleaseManagerTool', () => { ...commonSettings } as CommonSettings) - expect(args).toEqual(['--owner', 'owner', '--repository', 'repo', '--token', 'token', '--targetDirectory', 'targetDirectory']) + expect(args).toEqual([ + '--owner', + 'owner', + '--repository', + 'repo', + '--token', + 'token', + '--targetDirectory', + 'targetDirectory', + '--logFilePath', + './logFilePath' + ]) }) it('should throw error for non-existing target path', async () => { @@ -192,7 +204,8 @@ describe('GitReleaseManagerTool', () => { milestone: 'milestone', inputFileName: 'inputFileName', isPreRelease: true, - assets: ['asset1', 'asset2'] + assets: ['asset1', 'asset2'], + logFilePath: './createLogFilePath' } as CreateSettings) expect(args).toEqual([ @@ -205,6 +218,8 @@ describe('GitReleaseManagerTool', () => { 'token', '--targetDirectory', 'targetDirectory', + '--logFilePath', + './createLogFilePath', '--milestone', 'milestone', '--name', @@ -237,6 +252,8 @@ describe('GitReleaseManagerTool', () => { 'token', '--targetDirectory', 'targetDirectory', + '--logFilePath', + './logFilePath', '--milestone', 'milestone' ]) @@ -260,6 +277,8 @@ describe('GitReleaseManagerTool', () => { 'token', '--targetDirectory', 'targetDirectory', + '--logFilePath', + './logFilePath', '--milestone', 'milestone' ]) @@ -283,6 +302,8 @@ describe('GitReleaseManagerTool', () => { 'token', '--targetDirectory', 'targetDirectory', + '--logFilePath', + './logFilePath', '--milestone', 'milestone' ]) @@ -306,6 +327,8 @@ describe('GitReleaseManagerTool', () => { 'token', '--targetDirectory', 'targetDirectory', + '--logFilePath', + './logFilePath', '--tagName', 'milestone' ]) @@ -330,6 +353,8 @@ describe('GitReleaseManagerTool', () => { 'token', '--targetDirectory', 'targetDirectory', + '--logFilePath', + './logFilePath', '--tagName', 'milestone', '--assets',