Skip to content

Permissive Cross-domain Policy with Untrusted Domains ('Authorization Issues') [VID:15] #26

@veracode-workflow-app-preprod

Description

private String secret;
@CrossOrigin(origins = "*")
@RequestMapping(value = "/login", method = RequestMethod.POST, produces = "application/json", consumes = "application/json")
LoginResponse login(@RequestBody LoginRequest input) {
User user = User.fetch(input.username);
if (Postgres.md5(input.password).equals(user.hashedPassword)) {
return new LoginResponse(user.token(secret));
} else {
throw new Unauthorized("Access Denied");
}

Filename: LoginController.java

Line: 20

CWE: 942 (Permissive Cross-domain Policy with Untrusted Domains ('Authorization Issues'))

Cross-origin resource sharing (CORS) is a technique implemented by modern browsers to relax principles of same-origin policy, so that legitimate sites with different origins can interact with each other. Spring provides this support via @crossorigin annotation. Not restricting access to web resources (@crossorigin("*")), opens it up for attackers to inadvertently access restricted resources. An application should always check the origin of a request to be coming from a trusted source, before serving it. Please restrict the allowed domains which can access this resource References: CWE CORS support in Spring Framework REST Security Cheat Sheet at OWASP /nDon't know how to fix this? Don't know why this was reported?
Get Assistance from Veracode

Metadata

Metadata

Assignees

No one assigned

    Labels

    Veracode Policy ScanA Veracode Flaw found during a Policy or Sandbox ScanVeracodeFlaw: MediumA Veracode Flaw, Medium severity

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions