Does release.yml
not run when v*
tags are pushed?
#1970
Replies: 2 comments 7 replies
-
Unfortunately, these don't run even though they should.
That's a good point, the regex should obviously match the tag name (and did before), which may indicate that the event is either not registered, or it's not the right event. But here comes a hot take: I know it just stopped working without obvious cause, or one could say, over time. What changes with time? The amount of tags, as there are more and more crates. On another note: Can it be that there is no CI job anymore that would be installing from crates.io? I think the current release may actually be broken now (and I am investigating if that's the case for everyone).
|
Beta Was this translation helpful? Give feedback.
-
The causeIn git::push_tags_and_head(&ctx.base.repo, &tag_names, options.clone())?; This for tag_name in tag_names {
cmd.arg(tag_name.as_bstr().to_str()?);
} Thus, we push all the tags together. The GitHub Actions documentation on the
So I think that's the cause of the problem. Possible solutionsMultiple tag pushesThe simple solution of pushing each tag individually may be slower, though that probably does not matter. Or it may hit other rate limits, which may matter. I am also not certain that it would be sufficient: it might be that pushes within a very short time of each other are also considered to be "at once" for this purpose when they occur in quick enough succession, or in large numbers, or in some combination of quick succession and large numbers. While it's probably okay to be slower--and even to run much slower by inserting delays between the pushes to avoid aggravating other rate limits--the bigger problem with making We could push in groupsIdeally, for gitoxide, assuming I am right that this is the cause of the problem, we would have two separate tag pushes when there are tags for multiple crates including
But How that could workBecause the There would be various design decisions to make about how the grouping should work, but I suspect that the simple approach of always having two groups--tags that match a (By matching a The alternative of using a different eventAnother possible solution, for But I don't favor this alternative, because while the However, it may be that I am not looking in all the relevant places, or that the documentation is incomplete. So I'll try to look into that further when I have time to pick this back up, before dismissing the use of the Wait, am I right about the cause?The cause seems pretty straightforward, yet you may have noticed I've been hedging in my wording. The reason is that, from this comment, it sounds like running From the wording in that comment, I can't tell if it was saying the problem had recently started or not. That comment was posted in connection with the release that accompanied #1342, but I don't know that I should take it to mean that this was the first time the workflow didn't run on the |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
I've noticed that all runs of the
release
workflow seems to have been manually triggered, i.e. through theworkflow_dispatch
event. It also seems like creating thev*
tag forgitoxide
releases does not trigger it. For example, as of this writing, it has not yet run for v0.43.0, even though the tag and the GitHub release (with no added assets yet) exist.Is the tag being created in a way that is not considered a
push
event? I think even when a tag is created through the UI, it is a push event, but perhaps implicit tag creation due to the creation of a GitHub release does not do that--I am not sure. I believecargo-smart-release
creates and pushes the tag, but that it creates the release first, at least in draft form. If the tag is implicitly created in connection with the GitHub release before any tag is explicitly created or before a local tag is pushed, then maybe that could cause this? I don't know.Also, is this general situation, where the workflow is only run manually, intentional? Or is the workflow being manually triggered as a workaround for the
push
trigger not working?Beta Was this translation helpful? Give feedback.
All reactions