Mixing up (< and <=), (> and >=)?

[Borjomm]

I've spent some time looking and converting site of grace code.

Here:
--- in t000001000_x83 --- (Specific bonfire entityIds)
if GetEntityID() > 2048420950 and GetEntityID() < 2048420950:
elif GetEntityID() > 21010953 and GetEntityID() < 21010953:
elif GetEntityID() > 2049390950 and GetEntityID() < 2049390950:
Impossible states unless these are 'or equal'

--- in t000001000_x84 --- (Bonfire entityId in dlc)
if ((GetEntityID() > 20000000 and GetEntityID() < 28999999) or (GetEntityID() > 40000000 and GetEntityID()
< 43999999) or (GetEntityID() > 2000000000 and GetEntityID() < 2099999999)):
Almost sure these are inclusive

--- in t000001000_x7 --- (Golden Seed Upgrade)
if GetEstusAllocation(EstusType.HP) + GetEstusAllocation(EstusType.FP) < 13:

HP: 8, FP: 5: 13 Total, should allow for one more

--- in t000001000_x6 --- (Sacred Tear Upgrade)
if GetTotalBonfireLevel() <= 13:

Max BonfireLevel set by t000001000_x8 is 13, so it should check if it is less than that.

As much as I've encountered these, they are logically swapped with each other. Can we take a look?

[Borjomm]

0: CompareType.Equal
1: CompareType.NotEqual -> Less
2: CompareType.Greater
3: CompareType.Less -> LessOrEqual
4: CompareType.GreaterOrEqual
5: CompareType.LessOrEqual -> NotEqual

Also this (at least for elden ring). Absolutely sure about it. All of the code makes sense with it

1. def t000001000_x71(z18=3, action3=15000371):
2.    SetWorkValue(1, GetEstusAllocation(EstusType.HP) + GetEstusAllocation(EstusType.FP) + -4)
3.    assert GetGoldenSeedsNeeded(work_slot=1)
4.    # goods:10010:Golden Seed
5.    if (ComparePlayerInventoryNumber(ItemType.Goods, 10010, CompareType.NotEqual, GetWorkValue(1), False) or not
6.        GetEstusAllocation(EstusType.HP) + GetEstusAllocation(EstusType.FP) < 13): 
7.        # goods:10020:Sacred Tear
8.        if (ComparePlayerInventoryNumber(ItemType.Goods, 10020, CompareType.Less, 0, False) or not GetTotalBonfireLevel()
9.            <= 13):
10.           # action:15000371:"Flasks"
11.           AddTalkListDataAlt(z18, action3, -1, 0, False)
12.       else:
13.           Label('L0')
14.           # action:15000371:"Flasks"
15.           AddTalkListDataAlt(z18, action3, -1, 0, True)
16.   else:
17.       Goto('L0')
18.   SetWorkValue(1, 0)
19.    return 0

Line 5: if amount of golden seeds is LESS than needed, not NotEqual

Line 8. if amount of sacred tears is LessOrEqual than 0 (for negative action).
If it was Less, the highlight would emit if player had 0 tears

1. def t000001000_x26():
2.    call = t000001000_x1()
3.    if call.Done() and CompareBonfireLevel(CompareType.LessOrEqual, 0):
4.        pass
5.    elif call.Done():
6.        # actionbutton:6100:"Touch grace"
7.        call = t000001000_x3(actionbutton1=6100, flag8=6001, flag9=6000)
8.        if call.Done():
9.            TurnCharacterToFaceEntity(-1, 10000, -1, -1)
10.           assert GetCurrentStateElapsedFrames() > 1 and GetWhetherChrEventAnimHasEnded(10000)
11.           OfferHumanity()
12.           UpdatePlayerRespawnPoint()
13.           assert CompareBonfireLevel(CompareType.LessOrEqual, 0)
14.       elif CompareBonfireLevel(CompareType.LessOrEqual, 0):
15.           pass
16.   Quit()

Lines 3, 13 and 14. The logic only fires if the bonfire is not lit. NotEqual is exactly right.

And finally, the new ComparisonType list order does make sense