[WIP] Create Protection and ThermalLimits classes to delegate calculations from the backend #687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, Thanks for this. Can you please :
Thanks 😊 |
YacineAbd
changed the title
BDonnot
requested changes
Mar 6, 2025
| from grid2op.Backend.thermalLimits import ThermalLimits | ||
| from grid2op.Backend.protectionScheme import DefaultProtection, NoProtection | ||
|
|
||
| class TestProtection(unittest.TestCase): |
There was a problem hiding this comment.
General comment: coding language of grid2op is english. Would it be possible to translate all French here please ? Thanks
| self.default_protection._disconnect_lines(lines_to_disconnect, timestep=1) | ||
| self.mock_backend._disconnect_line.assert_called_once_with(1) | ||
|
|
||
| def test_next_grid_state(self): |
There was a problem hiding this comment.
For the "normal" protection there are 3 cases:
- no overflow with consequences: overflow counter is reset to 0, lines in this case are not disconnected
- "hard overflow" (flow above HARD_OVERFLOW_THRESHOLD * limit for a line), line is instantly disconnected and cannod be reconnected
- "soft overflow" : with two expected behaviour
- either the line is on overflow for less than "NB_TIMESTEP_OVERFLOW_ALLOWED" (or a similar name not checked in the code) in this case the only consquence is that the overflow counter is increased by 1
- or the line has been on overflow for more than "NB_TIMESTEP_OVERFLOW_ALLOWED" in this case the line is disconnected
If the line is disconnected, then another powerflow you be called.
The "overflow counter" should be increased by at most 1 for each powerline for a given call to "next_grid_state" (because a call to "next grid state" is supposed to happen instantly)
I am not sure all of the above are tested.
I don't see any test :
- for the overflow counter, in all cases
- for the soft overflow
- for the fact that the overflow counter should be increased by more than one (this is tricky to test and i'm not sure if it's covered in grid2op)
added 7 commits
March 7, 2025 15:37
…ace of next_grid function from backend
…s functionality, while the rest of the code remains unchanged.
Signed-off-by: yassine abdou <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.