Skip to content

Implement Lobstr wallet interception adapter #31

Description

@knytcomics-ui

Summary

Same shape as the xBull/Albedo adapter issues but for Lobstr (README.md:49) -- the fourth wallet named in the roadmap.

Current Behavior / Relevant Code

  • README.md:49; no Lobstr-specific code exists.

Why This Matters

Completes the four wallets explicitly named in the project's own roadmap, maximizing coverage of the Stellar wallet ecosystem with the WalletAdapter architecture.

Proposed Solution

  • Research Lobstr's signing-interception surface (browser extension vs. mobile-linked flows -- scope may need to explicitly exclude mobile-only signing if out of reach for a browser extension).
  • Implement and document accordingly, reusing the shared pipeline.

Acceptance Criteria

  • Lobstr signing requests (to the extent they occur in-browser) are intercepted and routed through the existing pipeline, with any out-of-scope flows clearly documented.

Definition of Done

  • npm run lint, npm run typecheck, npm test, and npm run build all pass locally and in CI
  • New or changed behavior is covered by unit tests (and integration/E2E tests where the change touches interception, background messaging, or the popup)
  • Any user-facing or architectural change is reflected in README.md
  • No regressions to the existing test suite or existing tier/interception behavior

How to Claim This Issue (Application Process)

  1. Comment first. Post a short implementation plan on this issue — your proposed approach, the files you expect to touch, and any open questions — before writing code. This prevents duplicate effort and lets a maintainer flag concerns early, which matters especially for an issue at this complexity level.
  2. Wait for assignment. A maintainer will review your plan and assign the issue to you, typically within 48 hours. Please do not open a draft PR before you're assigned.
  3. Stay active. If there's no visible activity (commits or comments) for 10 days after assignment, the issue may be unassigned and reopened to other contributors.
  4. Submit a scoped PR. Reference this issue (Closes #<issue-number>), keep the diff scoped to the acceptance criteria above, and ensure all CI gates pass before requesting review.
  5. Engage with review. Respond to review feedback within a reasonable timeframe; PRs with no response after 7 days may be closed pending resubmission when you're ready to pick it back up.

Category: Multi-Wallet Generalization
Estimated effort: L (large, ~1-2 weeks)
Difficulty: Advanced — this issue assumes familiarity with the codebase's MV3 service-worker architecture, the Freighter interception protocol, and/or the Stellar SDK.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions