Adding a single new configuration value currently touches four places in src/funcsort/config.py, plus a CLI flag in src/funcsort/main.py:
- the
Attributes: docstring section on Settings (l. 42-49)
- the
Settings dataclass field (l. 51-57)
- the
_Cfg descriptor inside class tool: class funcsort: (l. 80-84)
- the
Settings(...) kwarg in load_settings (l. 87-93)
plus Argument(...) in main.py for the CLI flag.
From the review of #2:
TODO for later, so creating an issue for this is required. Adding a new configuration value adds 4 new lines here, and one new line in main.py (althought that's just the CLI flags). That should be a single line added, using confkit's Config.
Goal: adding a config value should be a single confkit Config declaration, with Settings (or its replacement) derived from the confkit container rather than mirrored by hand.
Related: #5 — if args and settings become coupled, the merge lines at main.py:85-86 need re-reviewing.
Adding a single new configuration value currently touches four places in
src/funcsort/config.py, plus a CLI flag insrc/funcsort/main.py:Attributes:docstring section onSettings(l. 42-49)Settingsdataclass field (l. 51-57)_Cfgdescriptor insideclass tool: class funcsort:(l. 80-84)Settings(...)kwarg inload_settings(l. 87-93)plus
Argument(...)inmain.pyfor the CLI flag.From the review of #2:
Goal: adding a config value should be a single confkit
Configdeclaration, withSettings(or its replacement) derived from the confkit container rather than mirrored by hand.Related: #5 — if args and settings become coupled, the merge lines at
main.py:85-86need re-reviewing.