This repository was archived by the owner on Jan 1, 2019. It is now read-only.
Remove C unix mock for Badge python module #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is easier to implement this mock in python. Additionally, that opens up the possibility to keep the emulated code outside of the microptyhon repo, making the micropython repo more consistent with upstream again.
raboof
added a commit
to HackerHotel/Firmware
that referenced
this pull request
Nov 16, 2018
Restructured some bits to make it easier to fill in the blanks. With these changes the emulator can successfully start the launcher and the installer, though actually interacting with them is not yet supported. Additional benefit is that this allows moving some of the emulation code out of the micropython repo, keeping that repo more in sync with upstream. Merge HackerHotel/micropython-esp32#1 and update the submodule in this PR before merging this PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is easier to implement this mock in python. Additionally, that opens up the
possibility to keep the emulated code outside of the microptyhon repo, making
the micropython repo more consistent with upstream again.