Skip to content

Commit 0dc35da

Browse files
committed
🐛 bug: Resolve all objects rendering grey on loading new repo (#21)
Remove unnecessary state resets in `App`
1 parent 8b1f47f commit 0dc35da

File tree

2 files changed

+1
-12
lines changed

2 files changed

+1
-12
lines changed

src/components/App/App.jsx

-9
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ function App() {
3333

3434
useEffect(() => {
3535
if (objectData.objects !== undefined) {
36-
setIsLoading(true);
3736
const updatedObjectData = colorObjectsAndConnections(
3837
objectData,
3938
selectedCommits
@@ -109,10 +108,6 @@ function App() {
109108
setObjectData({});
110109

111110
if (isPackedRepo) setIsPackedRepo(false);
112-
if (selectedCommits.length !== 0) setSelectedCommits([]);
113-
if (Object.keys(rawDataObjDetails).length !== 0)
114-
setRawDataObjDetails({});
115-
if (Object.keys(objRawData).length !== 0) setObjRawData({});
116111
})
117112
.catch((err) => console.error("ERROR: ", err));
118113
};
@@ -134,10 +129,6 @@ function App() {
134129
if (showCommitSelector) setShowCommitSelector(false);
135130
setObjectData({ objects, objectConnections });
136131
if (isPackedRepo) setIsPackedRepo(false);
137-
if (Object.keys(rawDataObjDetails).length !== 0)
138-
setRawDataObjDetails({});
139-
if (Object.keys(objRawData).length !== 0) setObjRawData({});
140-
if (selectedCommits.length !== 0) setSelectedCommits([]);
141132
} catch (err) {
142133
if (err.message === "File not found.") setIsPackedRepo(true);
143134
}

src/components/CommitSelector/CommitSelector.jsx

+1-3
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,7 @@ const CommitSelector = ({
1515
const timeoutInstance = useRef();
1616

1717
useEffect(() => {
18-
if (selectedCommits.length === 0)
19-
setIsChecked(new Array(commits.length).fill(false));
20-
else {
18+
if (selectedCommits.length !== 0) {
2119
let updatedCheckedState = [];
2220
for (let i = 0; i < commits.length; i++) {
2321
if (

0 commit comments

Comments
 (0)