CppLib::setActiveHandle caused compiler error [macOS Catalina]

[JotaroS]

Hi,
I wanted to build shared library for seiral, and the compiler error happened at L23-25 of lib.cpp. Working branch is unity.

void CppLib::setActiveHandle(uint64_t handle)
{
    s_handle = (void *) handle; //replacing void * to FILEHANDLE fixed the compiler problem
}

compiler error was

/Users/jotaro/dualpantoframework/utils/serial/src/cppLib/lib.cpp:25:16: error: assigning to 'FILE *' (aka '__sFILE *') from incompatible type 'FILE **' (aka '__sFILE **'); dereference with *
    s_handle = (FILEHANDLE *) handle;

does this happen to other environment?

[Ferandal]

This is an issue with how the operating systems handle Filehandles
The current version is how Windows requires it (I decided to leave it so, because unity is oriented for windows machines)
MacOS and Linux require void pointer as you noticed

[Ferandal]

The right solution would be to automatically detect on which operating system the build is beeing done and load the right code

[JotaroS]

ok, so this should look like this:

void CppLib::setActiveHandle(uint64_t handle)
{
    #if __APPLE__
    s_handle = (FILEHANDLE) handle;
    #elif _WIN32
    s_handle = (void *) handle;
    #endif
}

Should this be for unity branch or develop branch?

[JotaroS]

@Ferandal any ideas?