Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should I do if the √N is not an integer? #11

Closed
ChaiJinhao opened this issue Nov 9, 2023 · 3 comments
Closed

What should I do if the √N is not an integer? #11

ChaiJinhao opened this issue Nov 9, 2023 · 3 comments

Comments

@ChaiJinhao
Copy link

What should I do if the √N is not an integer?

@Edenzzzz
Copy link

Just find the closest integer factor. That's also in their code.

@ChaiJinhao
Copy link
Author

Just find the closest integer factor. That's also in their code.

Thank you!!!

@DanFu09
Copy link
Collaborator

DanFu09 commented Nov 13, 2023

Yep, that's the right thing to do. We have a follow-up paper out now where we dive deeper into the tradeoffs for higher-order decompositions (focusing on the fixed FFT case, but many of the insights apply to the general case as well): https://github.com/HazyResearch/flash-fft-conv

We'll be moving the code into this codebase soon!

@DanFu09 DanFu09 closed this as completed Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants