Skip to content

fix(hql): DROP operation on empty traversals #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(hql): DROP operation on empty traversals #670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions helix-db/src/helix_engine/traversal_core/ops/util/drop.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use crate::helix_engine::{
bm25::bm25::BM25,
traversal_core::traversal_value::TraversalValue,
storage_core::{HelixGraphStorage, storage_methods::StorageMethods},
traversal_core::traversal_value::TraversalValue,
types::GraphError,
};
use heed3::RwTxn;
Expand All @@ -26,8 +26,9 @@ where
TraversalValue::Node(node) => match storage.drop_node(txn, &node.id) {
Ok(_) => {
if let Some(bm25) = &storage.bm25
&& let Err(e) = bm25.delete_doc(txn, node.id) {
println!("failed to delete doc from bm25: {e}");
&& let Err(e) = bm25.delete_doc(txn, node.id)
{
println!("failed to delete doc from bm25: {e}");
}
println!("Dropped node: {:?}", node.id);
Ok(())
Expand All @@ -42,6 +43,7 @@ where
Ok(_) => Ok(()),
Err(e) => Err(e),
},
TraversalValue::Empty => Ok(()),
_ => Err(GraphError::ConversionError(format!(
"Incorrect Type: {item:?}"
))),
Expand Down
Loading