-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve JSON API for Install Performance Improvements #19204
Comments
I like this approach and I'm excited to see what this will look like. This seems like an alternative approach to #16410 which maybe should get closed in favor of this one. I did some work on that at the time that got abandoned so feel free to change, use or remove any of the existing logic. |
Agreed, thanks. Yeh, we should remove the JSON v3 logic at some point before closing this issue. |
Okay, I'll get on removing the JSON v3 logic and I'll tag @Rylan12 to make sure I don't remove anything you plan on using. |
This hasn't been used in a around 8 months since the approach didn't work as well as we initially hoped. The idea was to reduce the size of the JSON blob to improve performance. This PR essentially reverts the following 2 commits: - 439c237 - 8e4d934 Related Links: - New approach: Homebrew/brew#19204 - Old approach: Homebrew/brew#16410
Verification
brew install wget
. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.Provide a detailed description of the proposed feature
The formula.json and cask.json files are downloaded almost every time an install or upgrade happens, and these files are large.
formula.arm64_sequoia.json
andcask.arm64_sequoia.json
brew info
orbrew search --desc —-eval-all
What is the motivation for the feature?
To make installing formulae and casks via the API faster
How will the feature be relevant to at least 90% of Homebrew users?
Increased performance for all API installs
What alternatives to the feature have been considered?
The text was updated successfully, but these errors were encountered: