Merge pull request #106 from heartexlabs/tests/async-fail

* Yield e2e output as artifact on fail
* Add example of catching errors in async codecept scripts
* Fix non-stable test with polygons

Author: hlomzik

.github/workflows/build.yml

@@ -42,6 +42,12 @@ jobs:
     - run: npm run test:e2e:headless
       if: github.event_name == 'push'
 
+    - uses: actions/upload-artifact@master
+      if: ${{ failure() }}
+      with:
+        name: e2e output
+        path: e2e/output/
+
     # upload this build as artifact to current Action
     - uses: actions/upload-artifact@master
       with:

e2e/tests/helpers.js

@@ -139,21 +139,29 @@ const clickMultipleKonva = async (points, done) => {
  * @param {function} done
  */
 const polygonKonva = async (points, done) => {
-  const delay = () => new Promise(resolve => setTimeout(resolve, 10));
-  const stage = window.Konva.stages[0];
-  const firstCoords = points[0];
-  for (let point of points) {
-    stage.fire("click", { evt: { offsetX: point[0], offsetY: point[1] } });
+  try {
+    const delay = () => new Promise(resolve => setTimeout(resolve, 10));
+    const stage = window.Konva.stages[0];
+    for (let point of points) {
+      stage.fire("click", { evt: { offsetX: point[0], offsetY: point[1] } });
+      await delay();
+    }
+
+    // this works in 50% runs for no reason; maybe some async lazy calculations
+    // const firstPoint = stage.getIntersection({ x, y });
+
+    // Circles (polygon points) redraw every new click so we can find it only after last click
+    const lastPoint = stage.find("Circle").slice(-1)[0];
+    const firstPoint = lastPoint.parent.find("Circle")[0];
+    // for closing the Polygon we should place cursor over the first point
+    firstPoint.fire("mouseover");
     await delay();
+    // and only after that we can click on it
+    firstPoint.fire("click");
+    done();
+  } catch (e) {
+    done(String(e));
   }
-
-  // for closing the Polygon we should place cursor over the first point
-  const firstPoint = stage.getIntersection({ x: firstCoords[0], y: firstCoords[1] });
-  firstPoint.fire("mouseover");
-  await delay();
-  // and only after that we can click on it
-  firstPoint.fire("click");
-  done();
 };
 
 /**

e2e/tests/image.shapes.test.js

@@ -143,7 +143,8 @@ Scenario("Simple shapes on Image", async function(I) {
 
     for (let region of shape.regions) {
       // draw the shape using corresponding helper and params
-      await I.executeAsyncScript(shape.action, ...region.params);
+      const err = await I.executeAsyncScript(shape.action, ...region.params);
+      if (err) throw new Error(err);
     }
 
     const result = await I.executeScript(serialize);