Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move init steps from fiscal_impact script to separate script #12

Open
lorae opened this issue Jun 4, 2024 · 0 comments
Open

Move init steps from fiscal_impact script to separate script #12

lorae opened this issue Jun 4, 2024 · 0 comments

Comments

@lorae
Copy link
Collaborator

lorae commented Jun 4, 2024

The fiscal_impact script currently has a miscellaneous section and a section A that are mostly initialization steps (confirm working directory, calculate current date, etc). As the script currently stands, they constitute lines 1 - 65.

It's up to our discretion to determine what should be in the main fiscal_impact script and what should be in a separate one, but I definitely think it would be helpful to at least have configuration steps - like the working directory setup and loading packages - in a different script. Preferably, we set up the project environment so it automatically loads. Likely, we'll end up with some sort of configuration script and keep some of the functionality from the "miscellaneous" and section A of the FIM in the main fiscal_impact script.

Thus, doing this task requires a few steps:

  1. understanding what the "miscellaneous" and Section A do and determining which lines of code should be transferred to a different script
  2. Determining whether the project already has a configuration script/environment
  3. Creating a new config script or adding relevant code to existing script
  4. Refactoring the code so it is cleaner.

This is a larger task and might better be split up into separate issues once we have a better grasp of the situation.

@lorae lorae converted this from a draft issue Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant