Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erroneous Q-space equations #51

Open
halvarsu opened this issue Apr 28, 2020 · 1 comment
Open

Erroneous Q-space equations #51

halvarsu opened this issue Apr 28, 2020 · 1 comment
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@halvarsu
Copy link
Collaborator

halvarsu commented Apr 28, 2020

The Q-space equations in OATDCC are based on the anti-symmetrized u-matrix elements, however Kvaal's 2012-article states that these should be derived from the non-anti-symmetrized matrix elements, as seen in eq 33 or more explicitly on page 5 of the appendix.

It seems like this requires us to also store and update a version of the non-anti-symmetrized matrix elements, which is a shame in computational terms. I have managed to implement a fix in the my hacked DVR-basis-oatdcc, which already stores u-matrix elements in their original form and anti-symmetrizes when needed (due to the sparse 2d representation). However, I find it an extremely open question how to best implement this in the "official" OATDCC.

@halvarsu halvarsu added bug Something isn't working invalid This doesn't seem right labels Apr 28, 2020
@haakoek
Copy link
Collaborator

haakoek commented Apr 28, 2020

One possibility is to contact Takeshi on mail and ask him how they do it: [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants