Skip to content

Commit efcac0d

Browse files
committed
publish v0.5.31 and use new process group for child
Signed-off-by: Mayank Sachan <[email protected]>
1 parent 8225175 commit efcac0d

File tree

3 files changed

+17
-12
lines changed

3 files changed

+17
-12
lines changed

.github/workflows/release.yml

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: Release
33
on:
44
push:
55
branches:
6-
- main
6+
- detach-process
77

88
jobs:
99
release:
@@ -16,8 +16,8 @@ jobs:
1616
- cos-csi-mounter
1717

1818
env:
19-
IS_LATEST_RELEASE: 'true'
20-
APP_VERSION: 1.0.4
19+
IS_LATEST_RELEASE: 'false'
20+
APP_VERSION: 0.5.31
2121

2222
steps:
2323
- name: Checkout Code
@@ -63,15 +63,11 @@ jobs:
6363
/home/runner/work/ibm-object-csi-driver/ibm-object-csi-driver/cos-csi-mounter/cos-csi-mounter-${{ env.APP_VERSION }}.deb.tar.gz.sha256
6464
/home/runner/work/ibm-object-csi-driver/ibm-object-csi-driver/cos-csi-mounter/cos-csi-mounter-${{ env.APP_VERSION }}.rpm.tar.gz
6565
/home/runner/work/ibm-object-csi-driver/ibm-object-csi-driver/cos-csi-mounter/cos-csi-mounter-${{ env.APP_VERSION }}.rpm.tar.gz.sha256
66-
tag_name: v1.0.4
67-
name: v1.0.4
66+
tag_name: v0.5.31
67+
name: v0.5.31
6868
body: |
6969
## 🚀 What’s New
70-
- Enable --vfs-cache-mode flag for rclone mount to support random write
71-
- Update golang dependencies
72-
- Fetch IAM Endpoint Dynamically
73-
- Add TLS cipher suites in the mount options
74-
- Fix issue with s3fs mount randomly taking time using IAM credentials on Private VPC clusters
70+
- Detach child process goup to fix rclone mount hang issue
7571
prerelease: ${{ env.IS_LATEST_RELEASE != 'true' }}
7672

7773
- name: Perform CodeQL Analysis

cos-csi-mounter/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
NAME := cos-csi-mounter
2-
APP_VERSION := 1.0.4
2+
APP_VERSION := 0.5.31
33
BUILD_DIR := $(NAME)-$(APP_VERSION)
44
BIN_DIR := bin
55

pkg/mounter/utils/mounter_utils.go

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,16 @@ type MounterOptsUtils struct {
3434
func (su *MounterOptsUtils) FuseMount(path string, comm string, args []string) error {
3535
klog.Info("-FuseMount-")
3636
klog.Infof("FuseMount params:\n\tpath: <%s>\n\tcommand: <%s>\n\targs: <%v>", path, comm, args)
37-
out, err := command(comm, args...).CombinedOutput()
37+
38+
cmd := exec.Command(comm, args...)
39+
40+
// Set the system process attribute
41+
// This is often used to prevent a child process from being killed
42+
// when its parent exits.
43+
cmd.SysProcAttr = &syscall.SysProcAttr{
44+
Setpgid: true, // Set a new process group ID for the child
45+
}
46+
out, err := cmd.CombinedOutput()
3847
if err != nil {
3948
klog.Warningf("FuseMount: mount command failed: mounter=%s, args=%v, error=%v, output=%s", comm, args, err, string(out))
4049
klog.Infof("FuseMount: checking if path already exists and is a mountpoint: path=%s", path)

0 commit comments

Comments
 (0)