Skip to content

Commit 091a12c

Browse files
authored
update/fix release logic in github actions (#373)
Signed-off-by: David Grove <[email protected]>
1 parent 53086c5 commit 091a12c

File tree

3 files changed

+18
-46
lines changed

3 files changed

+18
-46
lines changed

.github/workflows/ci.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -207,4 +207,4 @@ jobs:
207207
run: KAR_VERSION=$(git rev-parse --short "$GITHUB_SHA") DOCKER_REGISTRY=quay.io DOCKER_NAMESPACE=ibm DOCKER_IMAGE_TAG=latest make docker
208208
- name: Push Release Images
209209
if: ${{ env.PUSH_RELEASE == 'true' }}
210-
run: KAR_VERSION=${GITHUB_REF_NAME} DOCKER_REGISTRY=quay.io DOCKER_NAMESPACE=ibm DOCKER_IMAGE_TAG=${GITHUB_REF_NAME} make docker
210+
run: KAR_VERSION=${GITHUB_REF_NAME#v} DOCKER_REGISTRY=quay.io DOCKER_NAMESPACE=ibm DOCKER_IMAGE_TAG=${GITHUB_REF_NAME#v} make docker

.github/workflows/cli-release.yml

+16-45
Original file line numberDiff line numberDiff line change
@@ -22,64 +22,35 @@ on:
2222

2323
name: Make CLI Release
2424

25+
permissions:
26+
contents: write
27+
2528
jobs:
2629
build:
2730
name: Make CLI Release
2831
runs-on: ubuntu-latest
2932
if: github.repository == 'IBM/kar'
3033
steps:
3134
- name: Checkout code
32-
uses: actions/checkout@v2
35+
uses: actions/checkout@v3
3336
- name: Setup Go
3437
uses: actions/setup-go@v4
3538
with:
3639
go-version-file: 'core/go.mod'
3740
cache-dependency-path: 'core/go.sum'
38-
- name: Get Version
39-
id: get_version
40-
run: echo ::set-output name=VERSION::${GITHUB_REF/refs\/tags\/v}
41+
- name: Compute version
42+
run: echo "KAR_VERSION=${GITHUB_REF_NAME#v}" >> "$GITHUB_ENV"
4143
- name: Build CLI
4244
run: |
43-
KAR_VERSION=${{ steps.get_version.outputs.VERSION }} ./ci/build-cli-release.sh
45+
echo $KAR_VERSION
46+
./ci/build-cli-release.sh
4447
- name: Create Release
45-
id: create_release
46-
uses: actions/create-release@v1
47-
env:
48-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
49-
with:
50-
tag_name: ${{ github.ref }}
51-
release_name: Release ${{ steps.get_version.outputs.VERSION }}
52-
draft: false
53-
prerelease: false
54-
- name: Upload MacOS amd64
55-
id: upload-mac-amd64
56-
uses: actions/upload-release-asset@v1
57-
env:
58-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
59-
with:
60-
upload_url: ${{ steps.create_release.outputs.upload_url }}
61-
asset_path: ./core/build/kar-mac-amd64.zip
62-
asset_name: kar-mac-amd64.zip
63-
asset_content_type: application/zip
64-
- name: Upload Windows amd64
65-
id: upload-windows-amd64
66-
uses: actions/upload-release-asset@v1
67-
env:
68-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
48+
uses: softprops/action-gh-release@v1
6949
with:
70-
upload_url: ${{ steps.create_release.outputs.upload_url }}
71-
asset_path: ./core/build/kar-windows-amd64.zip
72-
asset_name: kar-windows-amd64.zip
73-
asset_content_type: application/zip
74-
- name: Upload Linux amd64
75-
id: upload-linux-amd64
76-
uses: actions/upload-release-asset@v1
77-
env:
78-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
79-
with:
80-
upload_url: ${{ steps.create_release.outputs.upload_url }}
81-
asset_path: ./core/build/kar-linux-amd64.tgz
82-
asset_name: kar-linux-amd64.tgz
83-
asset_content_type: application/gzip
84-
85-
50+
name: ${{ env.KAR_VERSION }}
51+
fail_on_unmatched_files: true
52+
files: |
53+
./core/build/kar-linux-amd64.tgz
54+
./core/build/kar-mac-amd64.zip
55+
./core/build/kar-mac-arm64.zip
56+
./core/build/kar-windows-amd64.zip

ci/build-cli-release.sh

+1
Original file line numberDiff line numberDiff line change
@@ -41,5 +41,6 @@ buildOne() {
4141
}
4242

4343
buildOne "darwin" "amd64"
44+
buildOne "darwin" "arm64"
4445
buildOne "linux" "amd64"
4546
buildOne "windows" "amd64"

0 commit comments

Comments
 (0)