This repository was archived by the owner on Jul 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 52
Add wasabi feedstock repo #135
Open
rjknight
wants to merge
12
commits into
IBM:master
Choose a base branch
from
rjknight:add-wasabi
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Haven't looked at the other recipes so don't know if this is actually possible, but.... The source repo seems to be pure python (no native C or C++ code, etc.), so could this be built as a |
jayfurmanek
suggested changes
Oct 29, 2019
Contributor
jayfurmanek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple quick changes and this one should be good to go.
jayfurmanek
approved these changes
Oct 29, 2019
Contributor
|
This recipe is in conda-forge as a noarch package. Do we need it here? |
Collaborator
Author
|
I tested out the thinc recipe and it looks like it picks up the existing conda-forge wasabi package ok, so I think we can probably skip this one but I'll leave it open until the others (spacy, thinc) are merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.