Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger only one rule to fail on an element, meta_redirect_optional Violation not meta_refresh_delay Needs Review #2176

Open
8 of 15 tasks
philljenkins opened this issue Jan 28, 2025 · 1 comment · May be fixed by #2239
Open
8 of 15 tasks
Assignees
Labels
ACT Issues/Rules related to ACT T70

Comments

@philljenkins
Copy link
Contributor

philljenkins commented Jan 28, 2025

While testing ACT meta related test cases, multiple rules are triggered for the same element with the issue.
I do not think this second rule should also trigger a Needs Review against the same element.

Checker rules

  • meta_redirect_optional is mapping to the ACT rule bisz58.
  • meta_refresh_delay is mapping to the ACT rule bc659a.

ACT rule bisz58 Meta element has no refresh delay (no exception) with 3 failed test cases:

Failed examples should be failed by at least one of the Checker rules fail reason codes.

  • Failed Example 1
    • Rule ID: meta_redirect_optional Reason ID: fail Violation
    • Rule ID: meta_refresh_delay Reason ID: potential_refresh Needs Review I do not think this second rule should also trigger against the same element.
  • Failed Example 2
    • Rule ID: meta_redirect_optional Reason ID: fail_longrefresh Violation
    • Rule ID: meta_refresh_delay Reason ID: potential_refresh Needs Review I do not think this second rule should also trigger against the same element.
  • Failed Example 3
    • Rule ID: meta_redirect_optional Reason ID: fail_longrefresh Violation
    • Rule ID: meta_refresh_delay Reason ID: potential_refresh Needs Review I do not think this second rule should also trigger against the same element.

ACT rule bc659a Meta element has no refresh delay with failed test cases:

@philljenkins philljenkins added the ACT Issues/Rules related to ACT label Jan 28, 2025
@philljenkins philljenkins changed the title Trigger only one rule to fail on an element, meta_redirect_optional or meta_refresh_delay Trigger only one rule to fail on an element, meta_redirect_optional Violation not meta_refresh_delay Needs Review Jan 28, 2025
@shunguoy shunguoy added the T70 label Feb 17, 2025
@shunguoy
Copy link
Contributor

triage: turn off the rule meta_redirect_optional so only report A and AA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACT Issues/Rules related to ACT T70
Projects
None yet
2 participants