refactor: remove redundant setting async

Author: HienTM

.eslintrc

@@ -1,5 +1,4 @@
 {
-  "extends": [
-    "react-ts"
-  ]
+  "extends": ["react-ts"],
+  "ignorePatterns": ["*.js"]
 }

.gitignore

@@ -1,2 +1,2 @@
-node_modules
-
+/node_modules
+/dist

dist/bootstrapMicroFrontend.d.ts

@@ -1,4 +1,4 @@
-import React from 'react';
+import { ComponentType } from 'react';
 import { MicroFrontendAppProps } from './types';
-declare const bootstrapMicroFrontend: (microFrontendName: string, App: React.ComponentType<MicroFrontendAppProps>, callback?: VoidFunction | undefined, rootId?: string) => void;
+declare const bootstrapMicroFrontend: (microFrontendName: string, App: ComponentType<MicroFrontendAppProps>, callback?: VoidFunction | undefined, rootId?: string) => void;
 export default bootstrapMicroFrontend;

dist/index.es.js

@@ -7,14 +7,16 @@
   "license": "MIT",
   "private": false,
   "source": "src/index.ts",
+  "main": "dist/index.es.js",
   "module": "dist/index.es.js",
   "types": "dist/index.d.ts",
   "files": [
     "dist/"
   ],
+  "sideEffects:": false,
   "scripts": {
-    "build": "rollup -c",
-    "build:config": "tsc rollup.config.ts --target es2017 --module es2015 --moduleResolution node --skipLibCheck --allowSyntheticDefaultImports --resolveJsonModule",
+    "build": "rollup -c rollup/rollup.config.js",
+    "build:config": "tsc -p rollup",
     "commit": "git-cz",
     "format": "prettier --write \"src/**/*.{ts,tsx,md}\"",
     "lint": "eslint 'src/**/*.{ts,tsx}'",
@@ -26,35 +28,34 @@
   },
   "dependencies": {
     "cb-react-micro-frontend-core": "^0.0.5",
-    "cb-toolset": "^0.1.2"
+    "cb-toolset": "^0.2.0"
   },
   "devDependencies": {
     "@commitlint/cli": "^8.3.5",
     "@commitlint/config-conventional": "^8.3.4",
-    "@rollup/plugin-node-resolve": "^7.1.3",
+    "@rollup/plugin-node-resolve": "^8.0.0",
     "@size-limit/preset-small-lib": "^4.5.0",
-    "@types/history": "^4.7.5",
     "@types/js-cookie": "^2.2.6",
-    "@types/node": "^13.13.5",
+    "@types/node": "^14.0.5",
     "@types/react": "^16.9.34",
     "@types/react-dom": "^16.9.7",
     "@types/react-router-dom": "^5.1.5",
+    "cb-rollup-plugin-filesize": "^9.0.0-5",
     "commitizen": "^4.1.2",
     "cz-conventional-changelog": "^3.2.0",
-    "del-cli": "^3.0.0",
+    "del-cli": "^3.0.1",
     "eslint": "^7.0.0",
     "eslint-config-react-ts": "^2.1.0",
     "husky": "^4.2.3",
-    "lint-staged": "^10.2.2",
+    "lint-staged": "^10.2.4",
     "react": "^16.13.1",
     "react-dom": "^16.13.1",
-    "release-it": "^13.5.8",
-    "rollup": "^2.8.2",
+    "release-it": "^13.6.1",
+    "rollup": "^2.10.5",
     "rollup-plugin-cleanup": "^3.1.1",
-    "rollup-plugin-filesize": "^8.0.2",
-    "rollup-plugin-typescript2": "^0.27.0",
+    "rollup-plugin-typescript2": "^0.27.1",
     "size-limit": "^4.5.0",
-    "typescript": "^3.8.3"
+    "typescript": "^3.9.3"
   },
   "peerDependencies": {
     "react": "> 16.8.0",

package.json

@@ -0,0 +1,32 @@
+import typescript from 'rollup-plugin-typescript2';
+import resolve from '@rollup/plugin-node-resolve';
+import cleanup from 'rollup-plugin-cleanup';
+import filesize from 'cb-rollup-plugin-filesize';
+import pkg from '../package.json';
+const external = [
+    'react',
+    'react-dom',
+    'react-router-dom',
+    'history',
+];
+const tsconfig = './tsconfig.json';
+const plugins = [
+    typescript({ tsconfig, clean: true }),
+    resolve(),
+    cleanup({ comments: 'none' }),
+    filesize(),
+];
+const watch = { include: ['src/**'] };
+const esOptions = {
+    input: pkg.source,
+    external,
+    output: {
+        file: pkg.module,
+        format: 'es',
+        sourcemap: true,
+    },
+    plugins,
+    watch,
+};
+const options = [esOptions];
+export default options;

rollup.config.js

@@ -3,10 +3,15 @@ import { RollupOptions, ExternalOption, Plugin, WatcherOptions } from 'rollup';
 import typescript from 'rollup-plugin-typescript2';
 import resolve from '@rollup/plugin-node-resolve';
 import cleanup from 'rollup-plugin-cleanup';
-import filesize from 'rollup-plugin-filesize';
-import pkg from './package.json';
+import filesize from 'cb-rollup-plugin-filesize';
+import pkg from '../package.json';
 
-const external: ExternalOption = ['react', 'react-dom', 'react-router-dom'];
+const external: ExternalOption = [
+  'react',
+  'react-dom',
+  'react-router-dom',
+  'history',
+];
 const tsconfig = './tsconfig.json';
 const plugins: Plugin[] = [
   typescript({ tsconfig, clean: true }),
@@ -22,6 +27,7 @@ const esOptions: RollupOptions = {
   output: {
     file: pkg.module,
     format: 'es',
+    sourcemap: true,
   },
   plugins,
   watch,

rollup/rollup.config.js

@@ -0,0 +1,27 @@
+{
+  "compilerOptions": {
+    "target": "ES2017",
+    "module": "ES2015",
+    "lib": ["ES2020"],
+    "allowJs": true,
+    "downlevelIteration": true,
+    "strict": true,
+    "noImplicitAny": true,
+    "strictNullChecks": true,
+    "strictFunctionTypes": true,
+    "strictBindCallApply": true,
+    "strictPropertyInitialization": true,
+    "noImplicitThis": true,
+    "alwaysStrict": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "noImplicitReturns": true,
+    "moduleResolution": "node",
+    "esModuleInterop": true,
+    "forceConsistentCasingInFileNames": true,
+    "skipLibCheck": true,
+    "allowSyntheticDefaultImports": true,
+    "resolveJsonModule": true
+  },
+  "include": ["."]
+}

rollup.config.ts renamed to rollup/rollup.config.ts

@@ -24,7 +24,6 @@ const loadScripts = (manifest: Manifest, host: string, scriptId: string) =>
       const entryUrl = resolveUrl(host, entry);
       const script = document.createElement('script');
       script.src = entryUrl;
-      script.async = true;
       script.crossOrigin = '';
       if (entryUrl === mainJsUrl) script.id = scriptId;
       script.onload = () => {