From 4e500906b26e855e6ea16ffcfc511694a990e165 Mon Sep 17 00:00:00 2001 From: Maximilian Date: Mon, 1 Apr 2019 09:18:15 +0900 Subject: [PATCH] Fix instance check of collections.iterable to remove DeprecationWarning and ensure future compatibility with python 3.8 --- h5py_wrapper/wrapper.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/h5py_wrapper/wrapper.py b/h5py_wrapper/wrapper.py index 09a568e..82b10be 100644 --- a/h5py_wrapper/wrapper.py +++ b/h5py_wrapper/wrapper.py @@ -172,7 +172,7 @@ def _dict_to_h5(f, d, overwrite_dataset, compression=None, parent_group=None): if parent_group is None: parent_group = f.parent for key, value in d.items(): - if isinstance(value, collections.MutableMapping): + if isinstance(value, collections.abc.MutableMapping): group_name = os.path.join(parent_group.name, str(key)) group = f.require_group(group_name) _dict_to_h5(f, value, overwrite_dataset, parent_group=group, @@ -227,7 +227,7 @@ def _create_dataset(parent_group, key, value, compression=None): dataset = parent_group.create_dataset( str(key), data=lib.convert_iterable_to_numpy_array(value), compression=compression) # ignore compression argument for scalar datasets - elif not isinstance(value, collections.Iterable): + elif not isinstance(value, collections.abc.Iterable): dataset = parent_group.create_dataset(str(key), data=value) else: dataset = parent_group.create_dataset(