Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use data_train in validation curve #809

Open
ArturoAmorQ opened this issue Mar 21, 2025 · 0 comments
Open

Use data_train in validation curve #809

ArturoAmorQ opened this issue Mar 21, 2025 · 0 comments
Labels
good first issue Good for newcomers

Comments

@ArturoAmorQ
Copy link
Collaborator

As reported in this forum post, in the instructions for the validation curve in the Exercise M6.03 it says

For both the gradient-boosting and random forest models, create a validation curve using the training set to assess the impact of the number of trees on the performance of each model.

But then in the solution we don't use the data_train but all data for the validation curve.

I guess we can take the opportunity to also emphasize that n_estimators should not be tuned, and that the validation curve in the notebook was only computed for educational purposes.

@ArturoAmorQ ArturoAmorQ added the good first issue Good for newcomers label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant