Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Switch to new projects_nodes repository #7109

Closed
wants to merge 18 commits into from
Closed

♻️ Switch to new projects_nodes repository #7109

wants to merge 18 commits into from

Conversation

giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Jan 28, 2025 •
edited
Loading

What do these changes do?

New projects_nodes repository is used instead of the old one, and all references to the workbench refer to the new columns in the new table.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo self-assigned this Jan 28, 2025
@giancarloromeo giancarloromeo added the t:maintenance Some planned maintenance work label Jan 28, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 30.18868% with 37 lines in your changes missing coverage. Please review.

Project coverage is 80.03%. Comparing base (15d54a6) to head (2e2779e).
Report is 3 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (15d54a6) and HEAD (2e2779e). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (15d54a6) HEAD (2e2779e)
unittests 30 24
integrationtests 6 4
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7109      +/-   ##
==========================================
- Coverage   87.69%   80.03%   -7.67%     
==========================================
  Files        1635     1465     -170     
  Lines       63939    58931    -5008     
  Branches     1176      944     -232     
==========================================
- Hits        56074    47165    -8909     
- Misses       7554    11506    +3952     
+ Partials      311      260      -51
Flag Coverage Δ
integrationtests 67.07% <28.30%> (+2.39%) ⬆️
unittests 69.08% <26.41%> (-16.92%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 94.02% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.39% <ø> (ø)
pkg_service_integration 70.18% <ø> (ø)
pkg_service_library 74.39% <ø> (ø)
pkg_settings_library 90.71% <ø> (ø)
pkg_simcore_sdk 85.50% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.55% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 90.33% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 76.92% <ø> (-0.09%) ⬇️
director_v2 64.09% <ø> (-27.18%) ⬇️
dynamic_scheduler 97.21% <ø> (ø)
dynamic_sidecar 89.78% <ø> (+0.03%) ⬆️
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 88.90% <ø> (-0.11%) ⬇️
storage 72.71% <ø> (-16.87%) ⬇️
webclient ∅ <ø> (∅)
webserver 74.96% <30.18%> (-11.24%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d54a6...2e2779e. Read the comment docs.

@giancarloromeo giancarloromeo added this to the Singularity milestone Jan 28, 2025
@giancarloromeo giancarloromeo added the 🤖-do-not-merge (optional) blocks Mergify from merging the PR label Jan 29, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
26.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@giancarloromeo giancarloromeo removed this from the Singularity milestone Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov will be requested when the pull request is marked ready for review pcrespov is a code owner

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg will be requested when the pull request is marked ready for review sanderegg is a code owner

@GitHK GitHK Awaiting requested review from GitHK GitHK will be requested when the pull request is marked ready for review GitHK is a code owner

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66 matusdrobuliak66 will be requested when the pull request is marked ready for review matusdrobuliak66 is a code owner

Assignees

@giancarloromeo giancarloromeo

Labels
🤖-do-not-merge (optional) blocks Mergify from merging the PR t:maintenance Some planned maintenance work
Projects
None yet
Milestone
No milestone
1 participant
@giancarloromeo