Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨E2E: add --service_version option #7083

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

🎨E2E: add --service_version option #7083

wants to merge 1 commit into from

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jan 24, 2025 •
edited
Loading

What do these changes do?

adds the option to define the service version in E2E tests

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the e2e Bugs found by or related to the end-2-end testing label Jan 24, 2025
@sanderegg sanderegg added this to the Singularity milestone Jan 24, 2025
@sanderegg sanderegg self-assigned this Jan 24, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link

codecov bot commented Jan 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.26%. Comparing base (e0a69be) to head (9e00fcc).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7083      +/-   ##
==========================================
- Coverage   87.26%   87.26%   -0.01%     
==========================================
  Files        1634     1634              
  Lines       64262    64262              
  Branches     2051     2051              
==========================================
- Hits        56078    56077       -1     
- Misses       7848     7849       +1     
  Partials      336      336
Flag Coverage Δ *Carryforward flag
integrationtests 63.68% <ø> (-4.17%) ⬇️
unittests 85.55% <ø> (ø) Carriedforward from e0a69be

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library 93.49% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.43% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.41% <ø> (ø)
pkg_service_integration 70.18% <ø> (ø)
pkg_service_library 74.13% <ø> (ø)
pkg_settings_library 90.49% <ø> (ø)
pkg_simcore_sdk 85.50% <ø> (ø)
agent 96.45% <ø> (ø)
api_server 90.55% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.32% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.92% <ø> (ø)
director_v2 91.28% <ø> (ø)
dynamic_scheduler 97.21% <ø> (ø)
dynamic_sidecar 89.75% <ø> (-0.04%) ⬇️
efs_guardian 90.39% <ø> (ø)
invitations 93.42% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 88.95% <ø> (ø)
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 84.92% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0a69be...9e00fcc. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66 matusdrobuliak66 will be requested when the pull request is marked ready for review matusdrobuliak66 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@sanderegg sanderegg

Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Milestone
Singularity
Development

Successfully merging this pull request may close these issues.

E2E: Add a test for pre-Vulkan sim4life
1 participant
@sanderegg