✨ Adding catalog client to dynamic-scheduler ⚠️
#7162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 4, 2025 11:57
GitHK
changed the title
catalog client to dynamic-schedulercatalog client to dynamic-scheduler ⚠️
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7162 +/- ##
==========================================
- Coverage 87.66% 87.47% -0.19%
==========================================
Files 1641 1262 -379
Lines 64171 53242 -10929
Branches 1179 718 -461
==========================================
- Hits 56253 46574 -9679
+ Misses 7607 6466 -1141
+ Partials 311 202 -109
Continue to review full report in Codecov by Sentry.
|
GitHK
requested review from
sanderegg,
mrnicegyu11,
YuryHrytsuk and
pcrespov
as code owners
matusdrobuliak66
approved these changes
Feb 4, 2025
YuryHrytsuk
approved these changes
Feb 4, 2025
giancarloromeo
approved these changes
Feb 4, 2025
added 2 commits
February 6, 2025 10:03
…alog-client-to-dynamic-scheduler
|
pcrespov
approved these changes
Feb 6, 2025
| return TypeAdapter(ServiceSpecifications).validate_python({}) | ||
|
|
||
|
|
||
| @pytest.fixture |
There was a problem hiding this comment.
please reuse pytest_simcore.faker_users_data fixtures
we have repeatedly discussed about this :-) ... can you please change all the fixtures in this service to use those.
There are many advantages by reusing these fixtures (can elaborate offline!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Adds catalog client to
dynamic-scheduler. Note: this client is not currently used.Related issue/s
dynamic-scheduler#7163How to test
Dev-ops checklist⚠️