Lumen support

[nnnikolay]

Do you have plan to support Lumen ?

Currently it does not work because of NewrelicServiceProvider and $app['router'] usage.

[pleckey]

@nnnikolay currently we aren't using Lumen for any projects, but I'm not against it. Happy to review a PR if it doesn't create any BC breaks.

[nnnikolay]

@pleckey I would love to do that. But there are few issue so far...

• First issue what I met is Router object, Lumen does not have the same Router as Laravel has, it means no such methods which been used in NewrelicServiceProvider can be solved with implementing LumenNewrelicServiceProvider.
• Another problem is filters, they are not exists in Lumen. There is a Middleware only. It means Lumen specific middleware should be created - LumenNewrelicMIddleware. And needs to be added into bootstrap/app.php like that

$app->middleware([
    App\Http\Middleware\LumenNewrelicMiddleware::class
 ]);

• Next problem is, facade usage. In Lumen I can use facade classes from the root namespace only if they are lumen's facades, this is how it is done in Lumen core.

            ...
            class_alias('Illuminate\Support\Facades\Cache', 'Cache');
            class_alias('Illuminate\Support\Facades\Cookie', 'Cookie');
            ...

it means we need to add similar line into the bootstrap/app.php

class_alias('Intouch\LaravelNewrelic\Facades\Newrelic', 'Newrelic');

Seems now it should work :)

[wirtsi]

In the LumenNewRelicMiddleWare (around line 95), could you please rewrite

foreach (\App::getRoutes() as $routeName => $route) {
            $regex = $routeToRegex($routeName);
            $method = $routeToMethod($routeName);
            $routes[$method.$regex] = compact('route', 'method', 'regex');
        }

to

        foreach (app()->getRoutes() as $routeName => $route) {
            $regex = $routeToRegex($routeName);
            $method = $routeToMethod($routeName);
            $routes[$method.$regex] = compact('route', 'method', 'regex');
        }

so it also works without the Facades being enabled

bests & thanks
wirtsi

[razvanphp]

I got another problem with Lumen when running

vagrant@server:~/feed-api$ php artisan vendor:publish --provider="Intouch\LaravelNewrelic\NewrelicServiceProvider"
PHP Fatal error:  Call to undefined function Intouch\LaravelNewrelic\config_path() in /home/vagrant/feed-api/vendor/intouch/laravel-newrelic/src/Intouch/LaravelNewrelic/NewrelicServiceProvider.php on line 41

  [Symfony\Component\Debug\Exception\FatalErrorException]
  Call to undefined function Intouch\LaravelNewrelic\config_path()

Is this related to Lumen - Laravel differences?

[JuanKman94]

#57 Using Lumen 5.5 app()->getRoutes() isn't working anymore