Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the comment field is filled out, submit the save action for that field prior to saving the underlying artifact. #278

Open
pedramamini opened this issue Dec 26, 2018 · 1 comment
Open

If the comment field is filled out, submit the save action for that field prior to saving the underlying artifact. #278

pedramamini opened this issue Dec 26, 2018 · 1 comment
Assignees
@danny248

Comments

@pedramamini
Copy link
Member

pedramamini commented Dec 26, 2018 •
edited by ofzza
Loading

When filling out the comment field, often times, we forget to hit the plus (+) action to save the comment:

image

If the user hits 'save' on the artifact on the bottom, the comment is lost. Can we either, detect an unsaved comment and block hitting save -or- auto submit any draft comments on artifact save?

Branch: issue/278-save-comment-on-modal-close (PR #345)
ofzza added a commit that referenced this issue Jun 5, 2019
@ofzza
COnfirming pending comment save with user on modal close (issue #278)
fa87649
@ofzza ofzza mentioned this issue Jun 5, 2019
Merged
@ofzza
Copy link
Contributor

ofzza commented Jun 5, 2019

@pedramamini @danny248
Made it so that if there is an unsaved comment, when saving or canceling the editing modal, the user will be prompted to save the comment first:
image

danny248 added a commit that referenced this issue Jun 5, 2019
@danny248
Merge pull request #345 from InQuest/issue/278-save-comment-on-modal-…
f4c4a74 
…close

Issue #278, If the comment field is filled out, submit the save action for that field prior to saving the underlying artifact
@battleoverflow battleoverflow moved this to Backlog in ThreatKB Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danny248 danny248

Labels
None yet
Projects
ThreatKB
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pedramamini @danny248 @ofzza