Avoid duplicated .NET names in model generation (Fix #50) #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A better approch to solving issue Intechnity-com#50 is juste to create a naming container and add an auto incremented suffix in case of duplicates. This way, we don't have to do the "+" and "-" hacks in the naming construction
Member
|
this is a very big change, please add some tests here |
Contributor
Author
|
Indeed. I’ll add tests later this week.
Le lun. 27 mars 2023 à 11:32, Patrick ***@***.***> a écrit :
… this is a very big change, please add some tests here
—
Reply to this email directly, view it on GitHub
<#62 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMT6TF4CHTJU4EPUJU3AEDW6FGCTANCNFSM6AAAAAAWHOHFZ4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A better approch to solving issue #50 is just to create a naming container and add an auto incremented suffix in case of duplicates. This way, we don't have to do the "+" and "-" hacks in the naming construction.
I took the opportunity to separate the Nullability question to a separate method as well because the rules are not that trivial.
This PR is a better alternative to #59 and I'm going to close #59 .